Update GetText.qll

bdrodes · web-flow · commit 88a06ffc66de · 2024-02-05T09:18:30.000-05:00
Fixing issue based on review.
diff --git a/cpp/ql/lib/semmle/code/cpp/models/implementations/GetText.qll b/cpp/ql/lib/semmle/code/cpp/models/implementations/GetText.qll
@@ -28,8 +28,6 @@ class GetTextFunction extends DataFlowFunction {
   GetTextFunction() { argInd = getTextArg(this) }
 
   override predicate hasDataFlow(FunctionInput input, FunctionOutput output) {
-    input.isParameter(argInd) and output.isReturnValue()
-    or
     input.isParameterDeref(argInd) and output.isReturnValueDeref()
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,6 @@ class GetTextFunction extends DataFlowFunction {`
`28`	`28`	`GetTextFunction() { argInd = getTextArg(this) }`
`29`	`29`
`30`	`30`	`override predicate hasDataFlow(FunctionInput input, FunctionOutput output) {`
`31`		`- input.isParameter(argInd) and output.isReturnValue()`
`32`		`- or`
`33`	`31`	`input.isParameterDeref(argInd) and output.isReturnValueDeref()`
`34`	`32`	`}`
`35`	`33`	`}`