Merge pull request github#19560 from owen-mc/java/add-stringreplaceallwithnonregex-test

Java: Add test showing correct usage

Author: owen-mc

java/ql/src/Performance/StringReplaceAllWithNonRegex.md

@@ -18,6 +18,7 @@ public class Test {
         String s1 = "test";
         s1 = s1.replaceAll("t", "x"); // NON_COMPLIANT
         s1 = s1.replaceAll(".*", "x"); // COMPLIANT
+        s1 = s1.replace("t", "x"); // COMPLIANT
     }
 }
 

java/ql/test/query-tests/StringReplaceAllWithNonRegex/Test.java

@@ -3,5 +3,6 @@ void f() {
         String s1 = "test";
         s1 = s1.replaceAll("t", "x"); // $ Alert // NON_COMPLIANT
         s1 = s1.replaceAll(".*", "x"); // COMPLIANT
+        s1 = s1.replace("t", "x"); // COMPLIANT
     }
 }