C++: Simplify 'parameterNeverEscapes' and add a comment.

MathiasVP · MathiasVP · commit 8bf8888c2412 · 2023-10-27T16:26:37.000+01:00
diff --git a/cpp/ql/lib/semmle/code/cpp/models/implementations/Strtol.qll b/cpp/ql/lib/semmle/code/cpp/models/implementations/Strtol.qll
@@ -28,7 +28,8 @@ private class Strtol extends AliasFunction, ArrayFunction, TaintFunction, SideEf
   }
 
   override predicate parameterNeverEscapes(int i) {
-    this.getParameter(i).getUnspecifiedType() instanceof PointerType
+    // Parameter 0 does escape into parameter 1.
+    i = 1
   }
 
   override predicate parameterEscapesOnlyViaReturn(int i) { none() }

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,8 @@ private class Strtol extends AliasFunction, ArrayFunction, TaintFunction, SideEf`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`override predicate parameterNeverEscapes(int i) {`
`31`		`- this.getParameter(i).getUnspecifiedType() instanceof PointerType`
	`31`	`+ // Parameter 0 does escape into parameter 1.`
	`32`	`+ i = 1`
`32`	`33`	`}`
`33`	`34`
`34`	`35`	`override predicate parameterEscapesOnlyViaReturn(int i) { none() }`