Skip to content

Commit 8db9187

Browse files
aschackmullaschackmull
committed
Go: Accept qltest .expected file changes (interesting).
1 parent e7f2431 commit 8db9187

File tree

4 files changed

+116
-69
lines changed

4 files changed

+116
-69
lines changed

‎go/ql/test/experimental/CWE-522-DecompressionBombs/DecompressionBombs.expected

Lines changed: 24 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -22,86 +22,87 @@ edges
2222
| test.go:128:20:128:27 | definition of filename | test.go:130:33:130:40 | filename | provenance | |
2323
| test.go:128:20:128:27 | definition of filename | test.go:143:51:143:58 | filename | provenance | |
2424
| test.go:130:2:130:41 | ... := ...[0] | test.go:132:12:132:12 | f | provenance | |
25-
| test.go:130:33:130:40 | filename | test.go:130:2:130:41 | ... := ...[0] | provenance | |
25+
| test.go:130:33:130:40 | filename | test.go:130:2:130:41 | ... := ...[0] | provenance | Config |
2626
| test.go:132:3:132:19 | ... := ...[0] | test.go:134:37:134:38 | rc | provenance | |
2727
| test.go:132:12:132:12 | f | test.go:132:3:132:19 | ... := ...[0] | provenance | MaD:8 |
2828
| test.go:143:2:143:59 | ... := ...[0] | test.go:144:20:144:37 | implicit dereference | provenance | |
29-
| test.go:143:51:143:58 | filename | test.go:143:2:143:59 | ... := ...[0] | provenance | |
29+
| test.go:143:51:143:58 | filename | test.go:143:2:143:59 | ... := ...[0] | provenance | Config |
3030
| test.go:144:20:144:37 | implicit dereference | test.go:144:20:144:37 | implicit dereference | provenance | |
3131
| test.go:144:20:144:37 | implicit dereference | test.go:144:20:144:37 | implicit read of field Reader | provenance | |
32+
| test.go:144:20:144:37 | implicit dereference | test.go:144:20:144:37 | implicit read of field Reader | provenance | Config |
3233
| test.go:144:20:144:37 | implicit read of field Reader | test.go:145:12:145:12 | f | provenance | |
33-
| test.go:145:12:145:12 | f | test.go:145:12:145:19 | call to Open | provenance | |
34+
| test.go:145:12:145:12 | f | test.go:145:12:145:19 | call to Open | provenance | Config |
3435
| test.go:145:12:145:19 | call to Open | test.go:147:37:147:38 | rc | provenance | |
3536
| test.go:158:19:158:22 | definition of file | test.go:159:25:159:28 | file | provenance | |
3637
| test.go:159:2:159:29 | ... := ...[0] | test.go:160:48:160:52 | file1 | provenance | |
3738
| test.go:159:25:159:28 | file | test.go:159:2:159:29 | ... := ...[0] | provenance | MaD:547 |
3839
| test.go:160:2:160:69 | ... := ...[0] | test.go:163:26:163:29 | file | provenance | |
39-
| test.go:160:32:160:53 | call to NewReader | test.go:160:2:160:69 | ... := ...[0] | provenance | |
40+
| test.go:160:32:160:53 | call to NewReader | test.go:160:2:160:69 | ... := ...[0] | provenance | Config |
4041
| test.go:160:48:160:52 | file1 | test.go:160:32:160:53 | call to NewReader | provenance | MaD:43 |
4142
| test.go:163:3:163:36 | ... := ...[0] | test.go:164:36:164:51 | fileReaderCloser | provenance | |
4243
| test.go:163:26:163:29 | file | test.go:163:3:163:36 | ... := ...[0] | provenance | MaD:8 |
4344
| test.go:169:28:169:31 | definition of file | test.go:170:25:170:28 | file | provenance | |
4445
| test.go:170:2:170:29 | ... := ...[0] | test.go:171:57:171:61 | file2 | provenance | |
4546
| test.go:170:25:170:28 | file | test.go:170:2:170:29 | ... := ...[0] | provenance | MaD:547 |
4647
| test.go:171:2:171:78 | ... := ...[0] | test.go:175:26:175:29 | file | provenance | |
47-
| test.go:171:41:171:62 | call to NewReader | test.go:171:2:171:78 | ... := ...[0] | provenance | |
48+
| test.go:171:41:171:62 | call to NewReader | test.go:171:2:171:78 | ... := ...[0] | provenance | Config |
4849
| test.go:171:57:171:61 | file2 | test.go:171:41:171:62 | call to NewReader | provenance | MaD:43 |
49-
| test.go:175:26:175:29 | file | test.go:175:26:175:36 | call to Open | provenance | |
50+
| test.go:175:26:175:29 | file | test.go:175:26:175:36 | call to Open | provenance | Config |
5051
| test.go:175:26:175:36 | call to Open | test.go:176:36:176:51 | fileReaderCloser | provenance | |
5152
| test.go:181:17:181:20 | definition of file | test.go:184:41:184:44 | file | provenance | |
5253
| test.go:184:2:184:73 | ... := ...[0] | test.go:186:2:186:12 | bzip2Reader | provenance | |
5354
| test.go:184:2:184:73 | ... := ...[0] | test.go:187:26:187:36 | bzip2Reader | provenance | |
54-
| test.go:184:41:184:44 | file | test.go:184:2:184:73 | ... := ...[0] | provenance | |
55+
| test.go:184:41:184:44 | file | test.go:184:2:184:73 | ... := ...[0] | provenance | Config |
5556
| test.go:187:12:187:37 | call to NewReader | test.go:189:18:189:24 | tarRead | provenance | |
5657
| test.go:187:26:187:36 | bzip2Reader | test.go:187:12:187:37 | call to NewReader | provenance | MaD:1 |
5758
| test.go:189:18:189:24 | tarRead | test.go:611:22:611:28 | definition of tarRead | provenance | |
5859
| test.go:208:12:208:15 | definition of file | test.go:211:33:211:36 | file | provenance | |
5960
| test.go:211:17:211:37 | call to NewReader | test.go:213:2:213:12 | bzip2Reader | provenance | |
6061
| test.go:211:17:211:37 | call to NewReader | test.go:214:26:214:36 | bzip2Reader | provenance | |
61-
| test.go:211:33:211:36 | file | test.go:211:17:211:37 | call to NewReader | provenance | |
62+
| test.go:211:33:211:36 | file | test.go:211:17:211:37 | call to NewReader | provenance | Config |
6263
| test.go:214:12:214:37 | call to NewReader | test.go:216:18:216:24 | tarRead | provenance | |
6364
| test.go:214:26:214:36 | bzip2Reader | test.go:214:12:214:37 | call to NewReader | provenance | MaD:1 |
6465
| test.go:216:18:216:24 | tarRead | test.go:611:22:611:28 | definition of tarRead | provenance | |
6566
| test.go:233:12:233:15 | definition of file | test.go:236:33:236:36 | file | provenance | |
6667
| test.go:236:17:236:37 | call to NewReader | test.go:238:2:238:12 | flateReader | provenance | |
6768
| test.go:236:17:236:37 | call to NewReader | test.go:239:26:239:36 | flateReader | provenance | |
68-
| test.go:236:33:236:36 | file | test.go:236:17:236:37 | call to NewReader | provenance | |
69+
| test.go:236:33:236:36 | file | test.go:236:17:236:37 | call to NewReader | provenance | Config |
6970
| test.go:239:12:239:37 | call to NewReader | test.go:241:18:241:24 | tarRead | provenance | |
7071
| test.go:239:26:239:36 | flateReader | test.go:239:12:239:37 | call to NewReader | provenance | MaD:1 |
7172
| test.go:241:18:241:24 | tarRead | test.go:611:22:611:28 | definition of tarRead | provenance | |
7273
| test.go:258:21:258:24 | definition of file | test.go:261:42:261:45 | file | provenance | |
7374
| test.go:261:17:261:46 | call to NewReader | test.go:263:2:263:12 | flateReader | provenance | |
7475
| test.go:261:17:261:46 | call to NewReader | test.go:264:26:264:36 | flateReader | provenance | |
75-
| test.go:261:42:261:45 | file | test.go:261:17:261:46 | call to NewReader | provenance | |
76+
| test.go:261:42:261:45 | file | test.go:261:17:261:46 | call to NewReader | provenance | Config |
7677
| test.go:264:12:264:37 | call to NewReader | test.go:266:18:266:24 | tarRead | provenance | |
7778
| test.go:264:26:264:36 | flateReader | test.go:264:12:264:37 | call to NewReader | provenance | MaD:1 |
7879
| test.go:266:18:266:24 | tarRead | test.go:611:22:611:28 | definition of tarRead | provenance | |
7980
| test.go:283:17:283:20 | definition of file | test.go:286:41:286:44 | file | provenance | |
8081
| test.go:286:2:286:73 | ... := ...[0] | test.go:288:2:288:12 | flateReader | provenance | |
8182
| test.go:286:2:286:73 | ... := ...[0] | test.go:289:26:289:36 | flateReader | provenance | |
82-
| test.go:286:41:286:44 | file | test.go:286:2:286:73 | ... := ...[0] | provenance | |
83+
| test.go:286:41:286:44 | file | test.go:286:2:286:73 | ... := ...[0] | provenance | Config |
8384
| test.go:289:12:289:37 | call to NewReader | test.go:291:18:291:24 | tarRead | provenance | |
8485
| test.go:289:26:289:36 | flateReader | test.go:289:12:289:37 | call to NewReader | provenance | MaD:1 |
8586
| test.go:291:18:291:24 | tarRead | test.go:611:22:611:28 | definition of tarRead | provenance | |
8687
| test.go:308:20:308:23 | definition of file | test.go:311:43:311:46 | file | provenance | |
8788
| test.go:311:2:311:47 | ... := ...[0] | test.go:313:2:313:11 | zlibReader | provenance | |
8889
| test.go:311:2:311:47 | ... := ...[0] | test.go:314:26:314:35 | zlibReader | provenance | |
89-
| test.go:311:43:311:46 | file | test.go:311:2:311:47 | ... := ...[0] | provenance | |
90+
| test.go:311:43:311:46 | file | test.go:311:2:311:47 | ... := ...[0] | provenance | Config |
9091
| test.go:314:12:314:36 | call to NewReader | test.go:316:18:316:24 | tarRead | provenance | |
9192
| test.go:314:26:314:35 | zlibReader | test.go:314:12:314:36 | call to NewReader | provenance | MaD:1 |
9293
| test.go:316:18:316:24 | tarRead | test.go:611:22:611:28 | definition of tarRead | provenance | |
9394
| test.go:333:11:333:14 | definition of file | test.go:336:34:336:37 | file | provenance | |
9495
| test.go:336:2:336:38 | ... := ...[0] | test.go:338:2:338:11 | zlibReader | provenance | |
9596
| test.go:336:2:336:38 | ... := ...[0] | test.go:339:26:339:35 | zlibReader | provenance | |
96-
| test.go:336:34:336:37 | file | test.go:336:2:336:38 | ... := ...[0] | provenance | |
97+
| test.go:336:34:336:37 | file | test.go:336:2:336:38 | ... := ...[0] | provenance | Config |
9798
| test.go:339:12:339:36 | call to NewReader | test.go:341:18:341:24 | tarRead | provenance | |
9899
| test.go:339:26:339:35 | zlibReader | test.go:339:12:339:36 | call to NewReader | provenance | MaD:1 |
99100
| test.go:341:18:341:24 | tarRead | test.go:611:22:611:28 | definition of tarRead | provenance | |
100101
| test.go:358:13:358:16 | definition of file | test.go:361:35:361:38 | file | provenance | |
101102
| test.go:361:18:361:39 | call to NewReader | test.go:363:2:363:13 | snappyReader | provenance | |
102103
| test.go:361:18:361:39 | call to NewReader | test.go:364:2:364:13 | snappyReader | provenance | |
103104
| test.go:361:18:361:39 | call to NewReader | test.go:365:26:365:37 | snappyReader | provenance | |
104-
| test.go:361:35:361:38 | file | test.go:361:18:361:39 | call to NewReader | provenance | |
105+
| test.go:361:35:361:38 | file | test.go:361:18:361:39 | call to NewReader | provenance | Config |
105106
| test.go:365:12:365:38 | call to NewReader | test.go:367:18:367:24 | tarRead | provenance | |
106107
| test.go:365:26:365:37 | snappyReader | test.go:365:12:365:38 | call to NewReader | provenance | MaD:1 |
107108
| test.go:367:18:367:24 | tarRead | test.go:611:22:611:28 | definition of tarRead | provenance | |
@@ -110,7 +111,7 @@ edges
110111
| test.go:387:18:387:48 | call to NewReader | test.go:391:2:391:13 | snappyReader | provenance | |
111112
| test.go:387:18:387:48 | call to NewReader | test.go:392:2:392:13 | snappyReader | provenance | |
112113
| test.go:387:18:387:48 | call to NewReader | test.go:393:26:393:37 | snappyReader | provenance | |
113-
| test.go:387:44:387:47 | file | test.go:387:18:387:48 | call to NewReader | provenance | |
114+
| test.go:387:44:387:47 | file | test.go:387:18:387:48 | call to NewReader | provenance | Config |
114115
| test.go:393:12:393:38 | call to NewReader | test.go:395:18:395:24 | tarRead | provenance | |
115116
| test.go:393:26:393:37 | snappyReader | test.go:393:12:393:38 | call to NewReader | provenance | MaD:1 |
116117
| test.go:395:18:395:24 | tarRead | test.go:611:22:611:28 | definition of tarRead | provenance | |
@@ -119,34 +120,34 @@ edges
119120
| test.go:415:14:415:31 | call to NewReader | test.go:418:2:418:9 | s2Reader | provenance | |
120121
| test.go:415:14:415:31 | call to NewReader | test.go:420:2:420:9 | s2Reader | provenance | |
121122
| test.go:415:14:415:31 | call to NewReader | test.go:421:26:421:33 | s2Reader | provenance | |
122-
| test.go:415:27:415:30 | file | test.go:415:14:415:31 | call to NewReader | provenance | |
123+
| test.go:415:27:415:30 | file | test.go:415:14:415:31 | call to NewReader | provenance | Config |
123124
| test.go:421:12:421:34 | call to NewReader | test.go:423:18:423:24 | tarRead | provenance | |
124125
| test.go:421:26:421:33 | s2Reader | test.go:421:12:421:34 | call to NewReader | provenance | MaD:1 |
125126
| test.go:423:18:423:24 | tarRead | test.go:611:22:611:28 | definition of tarRead | provenance | |
126127
| test.go:440:19:440:21 | definition of src | test.go:441:34:441:36 | src | provenance | |
127128
| test.go:441:2:441:37 | ... := ...[0] | test.go:444:12:444:32 | type conversion | provenance | |
128-
| test.go:441:34:441:36 | src | test.go:441:2:441:37 | ... := ...[0] | provenance | |
129+
| test.go:441:34:441:36 | src | test.go:441:2:441:37 | ... := ...[0] | provenance | Config |
129130
| test.go:444:12:444:32 | type conversion | test.go:445:23:445:28 | newSrc | provenance | |
130131
| test.go:447:11:447:14 | definition of file | test.go:450:34:450:37 | file | provenance | |
131132
| test.go:450:2:450:38 | ... := ...[0] | test.go:452:2:452:11 | gzipReader | provenance | |
132133
| test.go:450:2:450:38 | ... := ...[0] | test.go:453:26:453:35 | gzipReader | provenance | |
133-
| test.go:450:34:450:37 | file | test.go:450:2:450:38 | ... := ...[0] | provenance | |
134+
| test.go:450:34:450:37 | file | test.go:450:2:450:38 | ... := ...[0] | provenance | Config |
134135
| test.go:453:12:453:36 | call to NewReader | test.go:455:18:455:24 | tarRead | provenance | |
135136
| test.go:453:26:453:35 | gzipReader | test.go:453:12:453:36 | call to NewReader | provenance | MaD:1 |
136137
| test.go:455:18:455:24 | tarRead | test.go:611:22:611:28 | definition of tarRead | provenance | |
137138
| test.go:472:20:472:23 | definition of file | test.go:475:43:475:46 | file | provenance | |
138139
| test.go:475:2:475:47 | ... := ...[0] | test.go:477:2:477:11 | gzipReader | provenance | |
139140
| test.go:475:2:475:47 | ... := ...[0] | test.go:479:2:479:11 | gzipReader | provenance | |
140141
| test.go:475:2:475:47 | ... := ...[0] | test.go:480:26:480:35 | gzipReader | provenance | |
141-
| test.go:475:43:475:46 | file | test.go:475:2:475:47 | ... := ...[0] | provenance | |
142+
| test.go:475:43:475:46 | file | test.go:475:2:475:47 | ... := ...[0] | provenance | Config |
142143
| test.go:480:12:480:36 | call to NewReader | test.go:482:18:482:24 | tarRead | provenance | |
143144
| test.go:480:26:480:35 | gzipReader | test.go:480:12:480:36 | call to NewReader | provenance | MaD:1 |
144145
| test.go:482:18:482:24 | tarRead | test.go:611:22:611:28 | definition of tarRead | provenance | |
145146
| test.go:499:20:499:23 | definition of file | test.go:502:45:502:48 | file | provenance | |
146147
| test.go:502:2:502:49 | ... := ...[0] | test.go:504:2:504:12 | pgzipReader | provenance | |
147148
| test.go:502:2:502:49 | ... := ...[0] | test.go:506:2:506:12 | pgzipReader | provenance | |
148149
| test.go:502:2:502:49 | ... := ...[0] | test.go:507:26:507:36 | pgzipReader | provenance | |
149-
| test.go:502:45:502:48 | file | test.go:502:2:502:49 | ... := ...[0] | provenance | |
150+
| test.go:502:45:502:48 | file | test.go:502:2:502:49 | ... := ...[0] | provenance | Config |
150151
| test.go:507:12:507:37 | call to NewReader | test.go:509:18:509:24 | tarRead | provenance | |
151152
| test.go:507:26:507:36 | pgzipReader | test.go:507:12:507:37 | call to NewReader | provenance | MaD:1 |
152153
| test.go:509:18:509:24 | tarRead | test.go:611:22:611:28 | definition of tarRead | provenance | |
@@ -155,21 +156,21 @@ edges
155156
| test.go:529:2:529:47 | ... := ...[0] | test.go:533:2:533:11 | zstdReader | provenance | |
156157
| test.go:529:2:529:47 | ... := ...[0] | test.go:535:2:535:11 | zstdReader | provenance | |
157158
| test.go:529:2:529:47 | ... := ...[0] | test.go:536:26:536:35 | zstdReader | provenance | |
158-
| test.go:529:43:529:46 | file | test.go:529:2:529:47 | ... := ...[0] | provenance | |
159+
| test.go:529:43:529:46 | file | test.go:529:2:529:47 | ... := ...[0] | provenance | Config |
159160
| test.go:536:12:536:36 | call to NewReader | test.go:538:18:538:24 | tarRead | provenance | |
160161
| test.go:536:26:536:35 | zstdReader | test.go:536:12:536:36 | call to NewReader | provenance | MaD:1 |
161162
| test.go:538:18:538:24 | tarRead | test.go:611:22:611:28 | definition of tarRead | provenance | |
162163
| test.go:555:19:555:22 | definition of file | test.go:558:38:558:41 | file | provenance | |
163164
| test.go:558:16:558:42 | call to NewReader | test.go:560:2:560:11 | zstdReader | provenance | |
164165
| test.go:558:16:558:42 | call to NewReader | test.go:561:26:561:35 | zstdReader | provenance | |
165-
| test.go:558:38:558:41 | file | test.go:558:16:558:42 | call to NewReader | provenance | |
166+
| test.go:558:38:558:41 | file | test.go:558:16:558:42 | call to NewReader | provenance | Config |
166167
| test.go:561:12:561:36 | call to NewReader | test.go:563:18:563:24 | tarRead | provenance | |
167168
| test.go:561:26:561:35 | zstdReader | test.go:561:12:561:36 | call to NewReader | provenance | MaD:1 |
168169
| test.go:563:18:563:24 | tarRead | test.go:611:22:611:28 | definition of tarRead | provenance | |
169170
| test.go:580:9:580:12 | definition of file | test.go:583:30:583:33 | file | provenance | |
170171
| test.go:583:2:583:34 | ... := ...[0] | test.go:585:2:585:9 | xzReader | provenance | |
171172
| test.go:583:2:583:34 | ... := ...[0] | test.go:586:26:586:33 | xzReader | provenance | |
172-
| test.go:583:30:583:33 | file | test.go:583:2:583:34 | ... := ...[0] | provenance | |
173+
| test.go:583:30:583:33 | file | test.go:583:2:583:34 | ... := ...[0] | provenance | Config |
173174
| test.go:586:12:586:34 | call to NewReader | test.go:589:18:589:24 | tarRead | provenance | |
174175
| test.go:586:12:586:34 | call to NewReader | test.go:590:19:590:25 | tarRead | provenance | |
175176
| test.go:586:26:586:33 | xzReader | test.go:586:12:586:34 | call to NewReader | provenance | MaD:1 |

‎go/ql/test/library-tests/semmle/go/frameworks/Echo/OpenRedirect.expected

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,20 @@
11
edges
22
| test.go:172:2:172:6 | definition of param | test.go:173:20:173:24 | param | provenance | |
3+
| test.go:172:2:172:6 | definition of param | test.go:173:20:173:24 | param | provenance | Config |
34
| test.go:172:11:172:32 | call to Param | test.go:172:2:172:6 | definition of param | provenance | |
5+
| test.go:172:11:172:32 | call to Param | test.go:172:2:172:6 | definition of param | provenance | Config |
46
| test.go:178:2:178:6 | definition of param | test.go:182:24:182:28 | param | provenance | |
7+
| test.go:178:2:178:6 | definition of param | test.go:182:24:182:28 | param | provenance | Config |
58
| test.go:178:11:178:32 | call to Param | test.go:178:2:178:6 | definition of param | provenance | |
6-
| test.go:182:24:182:28 | param | test.go:182:20:182:28 | ...+... | provenance | |
9+
| test.go:178:11:178:32 | call to Param | test.go:178:2:178:6 | definition of param | provenance | Config |
10+
| test.go:182:24:182:28 | param | test.go:182:20:182:28 | ...+... | provenance | Config |
711
| test.go:190:2:190:4 | definition of url | test.go:193:21:193:23 | url | provenance | |
12+
| test.go:190:2:190:4 | definition of url | test.go:193:21:193:23 | url | provenance | Config |
813
| test.go:190:9:190:26 | star expression | test.go:190:2:190:4 | definition of url | provenance | |
9-
| test.go:190:9:190:26 | star expression | test.go:190:10:190:26 | selection of URL | provenance | |
10-
| test.go:190:10:190:26 | selection of URL | test.go:190:9:190:26 | star expression | provenance | |
11-
| test.go:193:21:193:23 | url | test.go:193:21:193:32 | call to String | provenance | |
14+
| test.go:190:9:190:26 | star expression | test.go:190:2:190:4 | definition of url | provenance | Config |
15+
| test.go:190:9:190:26 | star expression | test.go:190:10:190:26 | selection of URL | provenance | Config |
16+
| test.go:190:10:190:26 | selection of URL | test.go:190:9:190:26 | star expression | provenance | Config |
17+
| test.go:193:21:193:23 | url | test.go:193:21:193:32 | call to String | provenance | Config |
1218
nodes
1319
| test.go:172:2:172:6 | definition of param | semmle.label | definition of param |
1420
| test.go:172:11:172:32 | call to Param | semmle.label | call to Param |

0 commit comments

Comments
 (0)