Skip to content

Commit 8f1bccb

Browse files
JarLobadityasharad
andauthored
Apply suggestions from code review (comments)
Co-authored-by: Aditya Sharad <[email protected]>
1 parent 72b66ff commit 8f1bccb

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
---
22
category: minorAnalysis
33
---
4-
* Fixes and improvements in GitHub Actions Injection query.
4+
* Improved the queries for injection vulnerabilities in GitHub Actions workflows (`js/actions/command-injection` and `js/actions/pull-request-target`) and the associated library `semmle.javascript.Actions`. These now support steps defined in composite actions, in addition to steps defined in Actions workflow files.

javascript/ql/lib/semmle/javascript/Actions.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -234,10 +234,10 @@ module Actions {
234234
/** Gets the 0-based position of this step within the sequence of `steps`. */
235235
int getIndex() { result = index }
236236

237-
/** Gets the `job` this step belongs to. The step may belong to a `job` in a workflow or `runs` in a custom action. */
237+
/** Gets the `job` this step belongs to, if the step belongs to a `job` in a workflow. Has no result if the step belongs to `runs` in a custom action. */
238238
Job getJob() { result = parent }
239239

240-
/** Gets the `runs` this step belongs to. The step may belong to a `job` in a workflow or `runs` in a custom action. */
240+
/** Gets the `runs` this step belongs to, if the step belongs to a `runs` in a custom action. Has no result if the step belongs to a `job` in a workflow. */
241241
Runs getRuns() { result = parent }
242242

243243
/** Gets the value of the `uses` field in this step, if any. */

0 commit comments

Comments
 (0)