exclude tagged template literals from js/superfluous-trailing-arguments

Author: erik-krogh

javascript/ql/src/LanguageFeatures/SpuriousArguments.ql

@@ -46,7 +46,8 @@ class SpuriousArguments extends Expr {
 
   SpuriousArguments() {
     this = invk.getArgument(maxArity(invk)).asExpr() and
-    not invk.isIncomplete()
+    not invk.isIncomplete() and
+    not invk.getAstNode() instanceof TaggedTemplateExpr
   }
 
   /**

javascript/ql/test/query-tests/LanguageFeatures/SpuriousArguments/tst.js

@@ -129,4 +129,13 @@ function sum2() {
 }
 
 // OK
-sum2(1, 2, 3);
+sum2(1, 2, 3);
+
+const $ = function (x, arr) {
+  console.log(x, arr);
+};
+
+// OK
+async function tagThing(repoUrl, directory) {
+  await $`git clone ${repoUrl} ${directory}`;
+}