Skip to content

Commit 979d604

Browse files
Apply suggestions from code review
Co-authored-by: Aditya Sharad <[email protected]>
1 parent 5d2409e commit 979d604

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

actions/ql/src/Security/CWE-829/UnpinnedActionsTag.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ where
4040
) and
4141
uses.getVersion() = version and
4242
not isTrustedOwner(nwo) and
43-
not if isContainerImage(nwo) then isPinnedContainer(version) else isPinnedCommit(version) and
43+
not (if isContainerImage(nwo) then isPinnedContainer(version) else isPinnedCommit(version)) and
4444
not isImmutableAction(uses, nwo)
4545
select uses.getCalleeNode(),
4646
"Unpinned 3rd party Action '" + name + "' step $@ uses '" + nwo + "' with ref '" + version +

actions/ql/src/change-notes/2025-02-14-docker-false-positives.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
category: minorAnalysis
33
---
44

5-
* Fix CWE-829 false positives for Docker GitHub actions pinned by the container's SHA256 digest.
5+
* Fixed false positives in the query `actions/unpinned-tag` (CWE-829), which will no longer flag uses of Docker-based GitHub actions pinned by the container's SHA256 digest.

0 commit comments

Comments
 (0)