Skip to content

Commit 996364d

Browse files
committed
Python: Fix naming style guide violations
1 parent efec4e7 commit 996364d

File tree

5 files changed

+15
-14
lines changed

5 files changed

+15
-14
lines changed

python/ql/src/experimental/Security/CWE-208/TimingAttackAgainstHash/PossibleTimingAttackAgainstHash.ql

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,14 @@ import experimental.semmle.python.security.TimingAttack
2222
* A configuration that tracks data flow from cryptographic operations
2323
* to equality test
2424
*/
25-
private module PossibleTimingAttackAgainstHash implements DataFlow::ConfigSig {
25+
private module PossibleTimingAttackAgainstHashConfig implements DataFlow::ConfigSig {
2626
predicate isSource(DataFlow::Node source) { source instanceof ProduceCryptoCall }
2727

2828
predicate isSink(DataFlow::Node sink) { sink instanceof NonConstantTimeComparisonSink }
2929
}
3030

31-
module PossibleTimingAttackAgainstHashFlow = TaintTracking::Global<PossibleTimingAttackAgainstHash>;
31+
module PossibleTimingAttackAgainstHashFlow =
32+
TaintTracking::Global<PossibleTimingAttackAgainstHashConfig>;
3233

3334
import PossibleTimingAttackAgainstHashFlow::PathGraph
3435

python/ql/src/experimental/Security/CWE-340/TokenBuiltFromUUID.ql

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class TokenAssignmentValueSink extends DataFlow::Node {
3939
}
4040
}
4141

42-
private module TokenBuiltFromUUIDConfig implements DataFlow::ConfigSig {
42+
private module TokenBuiltFromUuidConfig implements DataFlow::ConfigSig {
4343
predicate isSource(DataFlow::Node source) { source instanceof PredictableResultSource }
4444

4545
predicate isSink(DataFlow::Node sink) { sink instanceof TokenAssignmentValueSink }
@@ -54,10 +54,10 @@ private module TokenBuiltFromUUIDConfig implements DataFlow::ConfigSig {
5454
}
5555

5656
/** Global taint-tracking for detecting "TokenBuiltFromUUID" vulnerabilities. */
57-
module TokenBuiltFromUUIDFlow = TaintTracking::Global<TokenBuiltFromUUIDConfig>;
57+
module TokenBuiltFromUuidFlow = TaintTracking::Global<TokenBuiltFromUuidConfig>;
5858

59-
import TokenBuiltFromUUIDFlow::PathGraph
59+
import TokenBuiltFromUuidFlow::PathGraph
6060

61-
from TokenBuiltFromUUIDFlow::PathNode source, TokenBuiltFromUUIDFlow::PathNode sink
62-
where TokenBuiltFromUUIDFlow::flowPath(source, sink)
61+
from TokenBuiltFromUuidFlow::PathNode source, TokenBuiltFromUuidFlow::PathNode sink
62+
where TokenBuiltFromUuidFlow::flowPath(source, sink)
6363
select sink.getNode(), source, sink, "Token built from $@.", source.getNode(), "predictable value"

python/ql/src/experimental/Security/CWE-522/LDAPInsecureAuth.ql

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212

1313
// determine precision above
1414
import python
15-
import LDAPInsecureAuthFlow::PathGraph
1615
import experimental.semmle.python.security.LDAPInsecureAuth
16+
import LdapInsecureAuthFlow::PathGraph
1717

18-
from LDAPInsecureAuthFlow::PathNode source, LDAPInsecureAuthFlow::PathNode sink
19-
where LDAPInsecureAuthFlow::flowPath(source, sink)
18+
from LdapInsecureAuthFlow::PathNode source, LdapInsecureAuthFlow::PathNode sink
19+
where LdapInsecureAuthFlow::flowPath(source, sink)
2020
select sink.getNode(), source, sink, "This LDAP host is authenticated insecurely."

python/ql/src/experimental/semmle/python/security/InsecureRandomness.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ module InsecureRandomness {
2121
* A taint-tracking configuration for reasoning about random values that are
2222
* not cryptographically secure.
2323
*/
24-
private module Configuration implements DataFlow::ConfigSig {
24+
private module Config implements DataFlow::ConfigSig {
2525
predicate isSource(DataFlow::Node source) { source instanceof Source }
2626

2727
predicate isSink(DataFlow::Node sink) { sink instanceof Sink }
@@ -30,5 +30,5 @@ module InsecureRandomness {
3030
}
3131

3232
/** Global taint-tracking for detecting "random values that are not cryptographically secure" vulnerabilities. */
33-
module Flow = TaintTracking::Global<Configuration>;
33+
module Flow = TaintTracking::Global<Config>;
3434
}

python/ql/src/experimental/semmle/python/security/LDAPInsecureAuth.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ class LdapStringVar extends BinaryExpr {
8888
/**
8989
* A taint-tracking configuration for detecting LDAP insecure authentications.
9090
*/
91-
private module LDAPInsecureAuthConfig implements DataFlow::ConfigSig {
91+
private module LdapInsecureAuthConfig implements DataFlow::ConfigSig {
9292
predicate isSource(DataFlow::Node source) {
9393
source instanceof RemoteFlowSource or
9494
source.asExpr() instanceof LdapFullHost or
@@ -104,4 +104,4 @@ private module LDAPInsecureAuthConfig implements DataFlow::ConfigSig {
104104
}
105105

106106
/** Global taint-tracking for detecting "LDAP insecure authentications" vulnerabilities. */
107-
module LDAPInsecureAuthFlow = TaintTracking::Global<LDAPInsecureAuthConfig>;
107+
module LdapInsecureAuthFlow = TaintTracking::Global<LdapInsecureAuthConfig>;

0 commit comments

Comments
 (0)