Skip to content

Commit 9e1c818

Browse files
committed
Python: address review comments
1 parent f5c176b commit 9e1c818

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

python/ql/test/experimental/dataflow/strange-essaflow/testFlow.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import python
22
import semmle.python.dataflow.new.DataFlow
33
private import semmle.python.dataflow.new.internal.DataFlowPrivate as DataFlowPrivate
44

5-
/** Gets the EssaNode that holds the module imported by the fully qualified module name `name` */
5+
/** Gets the `CfgNode` that holds the module imported by the fully qualified module name `name`. */
66
DataFlow::CfgNode module_import(string name) {
77
exists(Variable var, AssignmentDefinition def, Import imp, Alias alias |
88
var = def.getSourceVariable() and

python/ql/test/library-tests/frameworks/internal-ql-helpers/PoorMansFunctionResolutionTest.ql

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ module InlinePoorMansFunctionResolutionTest implements TestSig {
1515
not exists(FunctionDef def | def.getDefinedFunction() = func |
1616
ref.asExpr() = def.getATarget()
1717
) and
18-
// exclude things like `GSSA variable func`
19-
exists(ref.asExpr()) and
2018
// exclude decorator calls (which with our extractor rewrites does reference the
2119
// function)
2220
not ref.asExpr() = func.getDefinition().(FunctionExpr).getADecoratorCall()

0 commit comments

Comments
 (0)