Skip to content

Commit a0a8468

Browse files
authored
Merge pull request github#13124 from michaelnebel/csharp/dataflowconsistency-identity-only-source
C#: Only report dataflow inconsistencies (step to itself) in source code.
2 parents e402c22 + 59993ea commit a0a8468

File tree

14 files changed

+1
-4441
lines changed

14 files changed

+1
-4441
lines changed

csharp/ql/consistency-queries/DataFlowConsistency.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,5 +72,5 @@ private class MyConsistencyConfiguration extends ConsistencyConfiguration {
7272

7373
override predicate reverseReadExclude(Node n) { n.asExpr() = any(AwaitExpr ae).getExpr() }
7474

75-
override predicate identityLocalStepExclude(Node n) { this.missingLocationExclude(n) }
75+
override predicate identityLocalStepExclude(Node n) { n.getLocation().getFile().fromLibrary() }
7676
}

csharp/ql/test/library-tests/cil/attributes/CONSISTENCY/DataFlowConsistency.expected

Lines changed: 0 additions & 263 deletions
Large diffs are not rendered by default.

csharp/ql/test/library-tests/cil/consistency/CONSISTENCY/DataFlowConsistency.expected

Lines changed: 0 additions & 263 deletions
Large diffs are not rendered by default.

csharp/ql/test/library-tests/cil/dataflow/CONSISTENCY/DataFlowConsistency.expected

Lines changed: 0 additions & 263 deletions
Large diffs are not rendered by default.

csharp/ql/test/library-tests/cil/enums/CONSISTENCY/DataFlowConsistency.expected

Lines changed: 0 additions & 263 deletions
Large diffs are not rendered by default.

csharp/ql/test/library-tests/cil/functionPointers/CONSISTENCY/DataFlowConsistency.expected

Lines changed: 0 additions & 263 deletions
Large diffs are not rendered by default.

csharp/ql/test/library-tests/cil/init-only-prop/CONSISTENCY/DataFlowConsistency.expected

Lines changed: 0 additions & 263 deletions
Large diffs are not rendered by default.

csharp/ql/test/library-tests/cil/pdbs/CONSISTENCY/DataFlowConsistency.expected

Lines changed: 0 additions & 263 deletions
Large diffs are not rendered by default.

csharp/ql/test/library-tests/cil/regressions/CONSISTENCY/DataFlowConsistency.expected

Lines changed: 0 additions & 263 deletions
Large diffs are not rendered by default.

csharp/ql/test/library-tests/cil/typeAnnotations/CONSISTENCY/DataFlowConsistency.expected

Lines changed: 0 additions & 263 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)