Update powershell/ql/src/queries/security/cwe-319/UnsafeSMBSettings.ql

chanel-y · MathiasVP · web-flow · commit a0dbf930a2d1 · 2025-07-23T11:30:30.000-07:00
Co-authored-by: Mathias Vorreiter Pedersen &lt;mathiasvp@github.com&gt;
diff --git a/powershell/ql/src/queries/security/cwe-319/UnsafeSMBSettings.ql b/powershell/ql/src/queries/security/cwe-319/UnsafeSMBSettings.ql
@@ -20,7 +20,7 @@ abstract class SMBConfiguration extends CmdCall {
   Expr getMisconfiguredSmb2DialectMin() {
     exists(Expr dialectMin |
       dialectMin = this.getNamedArgument("smb2dialectmin") and
-      dialectMin.getValue().toString().toLowerCase() in ["none", "smb202", "smb210"] and
+      dialectMin.getValue().stringMatches(["none", "smb202", "smb210"]) and
       result = dialectMin
     )
   }

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ abstract class SMBConfiguration extends CmdCall {`
`20`	`20`	`Expr getMisconfiguredSmb2DialectMin() {`
`21`	`21`	`exists(Expr dialectMin \|`
`22`	`22`	`dialectMin = this.getNamedArgument("smb2dialectmin") and`
`23`		`- dialectMin.getValue().toString().toLowerCase() in ["none", "smb202", "smb210"] and`
	`23`	`+ dialectMin.getValue().stringMatches(["none", "smb202", "smb210"]) and`
`24`	`24`	`result = dialectMin`
`25`	`25`	`)`
`26`	`26`	`}`