Skip to content

Commit a1c3dca

Browse files
committed
JS: Convert OK-style to $-style expectations in one test
1 parent 8d01bbc commit a1c3dca

File tree

1 file changed

+11
-11
lines changed
  • javascript/ql/test/query-tests/AngularJS/DuplicateDependency

1 file changed

+11
-11
lines changed
Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
(function(){
22
function f(){}
3-
f.$inject = ['dup5', 'dup5']; // NOT OK
3+
f.$inject = ['dup5', 'dup5']; // $ Alert
44
angular.module('myModule', [])
5-
.run(['dup1a', 'dup1a', function(dup1a, dup1a){}]) // OK (flagged by js/duplicate-parameter-name)
6-
.run(['dup2a', 'dup2a', function(dup2a, dup2b){}]) // NOT OK
7-
.run(['dup3b', 'dup3b', function(dup3a, dup3b){}]) // NOT OK
8-
.run(['dup4', 'notDup4A', 'dup4', function(notDup4B, dup4, notDup4C){}]) // NOT OK
5+
.run(['dup1a', 'dup1a', function(dup1a, dup1a){}]) // OK - flagged by js/duplicate-parameter-name
6+
.run(['dup2a', 'dup2a', function(dup2a, dup2b){}]) // $ Alert
7+
.run(['dup3b', 'dup3b', function(dup3a, dup3b){}]) // $ Alert
8+
.run(['dup4', 'notDup4A', 'dup4', function(notDup4B, dup4, notDup4C){}]) // $ Alert
99
.run(f)
10-
.run(function(dup6, dup6){})// OK (flagged by js/duplicate-parameter-name)
11-
.run(function(notDup7a, notDup7b){}) // OK
12-
.run(['notDup8a', 'notDup8b', function(notDup8a, notDup8b){}]) // OK
13-
.run(['notDup9a', 'notDup9b', function(notDup9c, notDup9d){}]) // OK
14-
.run(['dup10a', 'dup10a', 'dup10a', function(dup10a, dup10a, dup10a){}]) // OK (flagged by js/duplicate-parameter-name)
15-
.run(['dup11a', 'dup11a', function(dup11a, dup11b){ // NOT OK (alert formatting for multi-line function)
10+
.run(function(dup6, dup6){})// OK - flagged by js/duplicate-parameter-name
11+
.run(function(notDup7a, notDup7b){})
12+
.run(['notDup8a', 'notDup8b', function(notDup8a, notDup8b){}])
13+
.run(['notDup9a', 'notDup9b', function(notDup9c, notDup9d){}])
14+
.run(['dup10a', 'dup10a', 'dup10a', function(dup10a, dup10a, dup10a){}]) // OK - flagged by js/duplicate-parameter-name
15+
.run(['dup11a', 'dup11a', function(dup11a, dup11b){ // $ Alert - alert formatting for multi-line function
1616
}])
1717
;
1818
})();

0 commit comments

Comments
 (0)