C#: Update most other test cases to reflect the synthesized constructor calls and bodies.

Author: michaelnebel

csharp/ql/test/library-tests/controlflow/splits/SplittingStressTest.expected

@@ -1,4 +1,6 @@
 countSplits
+| SplittingStressTest.cs:1:7:1:25 | call to constructor Object | 1 |
+| SplittingStressTest.cs:1:7:1:25 | {...} | 1 |
 | SplittingStressTest.cs:4:5:168:5 | {...} | 1 |
 | SplittingStressTest.cs:5:9:6:13 | if (...) ... | 1 |
 | SplittingStressTest.cs:5:13:5:14 | access to parameter b1 | 1 |

csharp/ql/test/library-tests/csharp8/NullableRefTypes.expected

@@ -239,6 +239,7 @@ annotatedTypeConstraints
 | NullableRefTypes.cs:58:24:58:25 | T2 | NullableRefTypes.cs:54:11:54:33 | Generic<string?, T1?, IEnumerable<string?>!, MyClass!>! |
 typeNotAnnotated
 expressionTypes
+| NullableRefTypes.cs:6:7:6:13 | call to constructor Object | object |
 | NullableRefTypes.cs:13:19:13:22 | null | null |
 | NullableRefTypes.cs:14:18:14:21 | this access | MyClass! |
 | NullableRefTypes.cs:17:29:17:32 | null | null |
@@ -265,6 +266,8 @@ expressionTypes
 | NullableRefTypes.cs:40:26:40:30 | ref ... | MyClass |
 | NullableRefTypes.cs:40:30:40:30 | access to local variable b | MyClass? |
 | NullableRefTypes.cs:51:44:51:47 | null | null |
+| NullableRefTypes.cs:54:11:54:33 | call to constructor Object | object |
+| NullableRefTypes.cs:58:11:58:26 | call to constructor Object | object |
 | NullableRefTypes.cs:73:18:73:18 | access to local variable x | MyClass! |
 | NullableRefTypes.cs:73:18:73:25 | MyClass x = ... | MyClass! |
 | NullableRefTypes.cs:73:22:73:25 | null | null |
@@ -276,6 +279,7 @@ expressionTypes
 | NullableRefTypes.cs:75:11:75:11 | access to local variable x | MyClass? |
 | NullableRefTypes.cs:76:16:76:32 | default(...) | MyStruct! |
 | NullableRefTypes.cs:76:24:76:31 | access to type MyStruct | MyStruct |
+| NullableRefTypes.cs:80:7:80:22 | call to constructor Object | object |
 | NullableRefTypes.cs:84:17:84:17 | access to local variable x | string! |
 | NullableRefTypes.cs:84:17:84:28 | String x = ... | string! |
 | NullableRefTypes.cs:84:21:84:28 | "source" | string! |
@@ -308,6 +312,7 @@ expressionTypes
 | NullableRefTypes.cs:96:9:96:15 | access to type Console | Console! |
 | NullableRefTypes.cs:96:9:96:28 | call to method WriteLine | Void! |
 | NullableRefTypes.cs:96:27:96:27 | access to local variable x | string? |
+| NullableRefTypes.cs:100:7:100:14 | call to constructor Object | object |
 | NullableRefTypes.cs:103:48:103:52 | ref ... | MyClass |
 | NullableRefTypes.cs:103:52:103:52 | access to parameter r | MyClass! |
 | NullableRefTypes.cs:104:48:104:52 | ref ... | MyClass |
@@ -326,11 +331,16 @@ expressionTypes
 | NullableRefTypes.cs:113:36:113:43 | access to field Property | MyClass? |
 | NullableRefTypes.cs:113:36:113:43 | this access | RefTypes |
 | NullableRefTypes.cs:113:36:113:44 | ...! | MyClass? |
+| NullableRefTypes.cs:116:7:116:23 | call to constructor Object | object |
+| NullableRefTypes.cs:136:7:136:24 | call to constructor Object | object |
+| NullableRefTypes.cs:154:7:154:25 | call to constructor Object | object |
 | NullableRefTypes.cs:157:18:157:30 | object creation of type MyClass | MyClass |
 | NullableRefTypes.cs:160:17:160:17 | access to local variable a | MyClass |
 | NullableRefTypes.cs:160:17:160:21 | MyClass a = ... | MyClass |
 | NullableRefTypes.cs:160:21:160:21 | access to parameter p | MyClass |
 | NullableRefTypes.cs:161:16:161:16 | access to local variable a | MyClass |
+| NullableRefTypes.cs:165:8:165:15 | call to constructor ValueType | ValueType |
+| NullableRefTypes.cs:171:16:171:37 | call to constructor Object | object |
 | NullableRefTypes.cs:181:17:181:17 | access to local variable x | string! |
 | NullableRefTypes.cs:181:17:181:31 | String x = ... | string! |
 | NullableRefTypes.cs:181:21:181:31 | call to method MaybeNull | string? |

csharp/ql/test/library-tests/csharp9/nativeInt.expected

@@ -1,3 +1,4 @@
+| NativeInt.cs:3:14:3:22 | call to constructor Object | Object |
 | NativeInt.cs:7:14:7:14 | access to local variable x | IntPtr |
 | NativeInt.cs:7:14:7:18 | IntPtr x = ... | IntPtr |
 | NativeInt.cs:7:18:7:18 | (...) ... | IntPtr |

csharp/ql/test/library-tests/dataflow/global/GetAnOutNode.expected

@@ -1,3 +1,4 @@
+| Capture.cs:5:7:5:13 | call to constructor Object | normal | Capture.cs:5:7:5:13 | call to constructor Object |
 | Capture.cs:33:9:33:40 | call to method Select<String,String> | normal | Capture.cs:33:9:33:40 | call to method Select<String,String> |
 | Capture.cs:33:9:33:50 | call to method ToArray<String> | normal | Capture.cs:33:9:33:50 | call to method ToArray<String> |
 | Capture.cs:71:9:71:21 | call to local function CaptureOut1 | captured sink30 | Capture.cs:71:9:71:21 | SSA call def(sink30) |
@@ -17,6 +18,7 @@
 | Capture.cs:191:20:191:22 | call to local function M | normal | Capture.cs:191:20:191:22 | call to local function M |
 | Capture.cs:194:22:194:32 | call to local function Id | normal | Capture.cs:194:22:194:32 | call to local function Id |
 | Capture.cs:196:20:196:25 | call to local function Id | normal | Capture.cs:196:20:196:25 | call to local function Id |
+| GlobalDataFlow.cs:13:14:13:21 | call to constructor Object | normal | GlobalDataFlow.cs:13:14:13:21 | call to constructor Object |
 | GlobalDataFlow.cs:26:9:26:26 | access to property SinkProperty0 | normal | GlobalDataFlow.cs:26:9:26:26 | access to property SinkProperty0 |
 | GlobalDataFlow.cs:27:15:27:32 | access to property SinkProperty0 | normal | GlobalDataFlow.cs:27:15:27:32 | access to property SinkProperty0 |
 | GlobalDataFlow.cs:30:9:30:29 | access to property NonSinkProperty0 | normal | GlobalDataFlow.cs:30:9:30:29 | access to property NonSinkProperty0 |
@@ -147,24 +149,28 @@
 | GlobalDataFlow.cs:249:24:249:34 | access to property Result | normal | GlobalDataFlow.cs:249:24:249:34 | access to property Result |
 | GlobalDataFlow.cs:300:17:300:38 | call to method ApplyFunc<T,T> | normal | GlobalDataFlow.cs:300:17:300:38 | call to method ApplyFunc<T,T> |
 | GlobalDataFlow.cs:389:16:389:19 | delegate call | normal | GlobalDataFlow.cs:389:16:389:19 | delegate call |
+| GlobalDataFlow.cs:415:11:415:14 | call to constructor Object | normal | GlobalDataFlow.cs:415:11:415:14 | call to constructor Object |
 | GlobalDataFlow.cs:448:22:448:65 | call to method Join | normal | GlobalDataFlow.cs:448:22:448:65 | call to method Join |
 | GlobalDataFlow.cs:451:23:451:65 | call to method Join | normal | GlobalDataFlow.cs:451:23:451:65 | call to method Join |
 | GlobalDataFlow.cs:457:20:457:49 | call to method Run<String> | normal | GlobalDataFlow.cs:457:20:457:49 | call to method Run<String> |
 | GlobalDataFlow.cs:458:25:458:50 | call to method ConfigureAwait | normal | GlobalDataFlow.cs:458:25:458:50 | call to method ConfigureAwait |
 | GlobalDataFlow.cs:459:23:459:44 | call to method GetAwaiter | normal | GlobalDataFlow.cs:459:23:459:44 | call to method GetAwaiter |
 | GlobalDataFlow.cs:460:22:460:40 | call to method GetResult | normal | GlobalDataFlow.cs:460:22:460:40 | call to method GetResult |
+| GlobalDataFlow.cs:476:18:476:28 | call to constructor Object | normal | GlobalDataFlow.cs:476:18:476:28 | call to constructor Object |
 | GlobalDataFlow.cs:488:18:488:34 | object creation of type SimpleClass | normal | GlobalDataFlow.cs:488:18:488:34 | object creation of type SimpleClass |
 | GlobalDataFlow.cs:489:18:489:34 | object creation of type SimpleClass | normal | GlobalDataFlow.cs:489:18:489:34 | object creation of type SimpleClass |
 | GlobalDataFlow.cs:494:18:494:34 | object creation of type SimpleClass | normal | GlobalDataFlow.cs:494:18:494:34 | object creation of type SimpleClass |
 | GlobalDataFlow.cs:495:18:495:34 | object creation of type SimpleClass | normal | GlobalDataFlow.cs:495:18:495:34 | object creation of type SimpleClass |
 | GlobalDataFlow.cs:496:18:496:34 | object creation of type SimpleClass | normal | GlobalDataFlow.cs:496:18:496:34 | object creation of type SimpleClass |
+| GlobalDataFlow.cs:503:19:503:32 | call to constructor SimpleClass | normal | GlobalDataFlow.cs:503:19:503:32 | call to constructor SimpleClass |
 | GlobalDataFlow.cs:507:17:507:36 | object creation of type SubSimpleClass | normal | GlobalDataFlow.cs:507:17:507:36 | object creation of type SubSimpleClass |
 | GlobalDataFlow.cs:514:17:514:33 | object creation of type SimpleClass | normal | GlobalDataFlow.cs:514:17:514:33 | object creation of type SimpleClass |
 | GlobalDataFlow.cs:522:17:522:33 | object creation of type SimpleClass | normal | GlobalDataFlow.cs:522:17:522:33 | object creation of type SimpleClass |
 | GlobalDataFlow.cs:523:17:523:33 | object creation of type SimpleClass | normal | GlobalDataFlow.cs:523:17:523:33 | object creation of type SimpleClass |
 | GlobalDataFlow.cs:524:17:524:33 | object creation of type SimpleClass | normal | GlobalDataFlow.cs:524:17:524:33 | object creation of type SimpleClass |
 | GlobalDataFlow.cs:545:17:545:33 | object creation of type SimpleClass | normal | GlobalDataFlow.cs:545:17:545:33 | object creation of type SimpleClass |
 | GlobalDataFlow.cs:558:44:558:47 | delegate call | normal | GlobalDataFlow.cs:558:44:558:47 | delegate call |
+| GlobalDataFlowStringBuilder.cs:13:14:13:34 | call to constructor Object | normal | GlobalDataFlowStringBuilder.cs:13:14:13:34 | call to constructor Object |
 | GlobalDataFlowStringBuilder.cs:19:9:19:20 | call to method Append | normal | GlobalDataFlowStringBuilder.cs:19:9:19:20 | call to method Append |
 | GlobalDataFlowStringBuilder.cs:24:9:24:27 | call to method Append | normal | GlobalDataFlowStringBuilder.cs:24:9:24:27 | call to method Append |
 | GlobalDataFlowStringBuilder.cs:29:18:29:36 | object creation of type StringBuilder | normal | GlobalDataFlowStringBuilder.cs:29:18:29:36 | object creation of type StringBuilder |
@@ -178,6 +184,7 @@
 | GlobalDataFlowStringBuilder.cs:44:9:44:18 | call to method Clear | normal | GlobalDataFlowStringBuilder.cs:44:9:44:18 | call to method Clear |
 | GlobalDataFlowStringBuilder.cs:45:23:45:35 | call to method ToString | normal | GlobalDataFlowStringBuilder.cs:45:23:45:35 | call to method ToString |
 | GlobalDataFlowStringBuilder.cs:49:21:49:33 | call to method ToString | normal | GlobalDataFlowStringBuilder.cs:49:21:49:33 | call to method ToString |
+| Splitting.cs:1:7:1:15 | call to constructor Object | normal | Splitting.cs:1:7:1:15 | call to constructor Object |
 | Splitting.cs:8:17:8:31 | [b (line 3): false] call to method Return<String> | normal | Splitting.cs:8:17:8:31 | [b (line 3): false] call to method Return<String> |
 | Splitting.cs:8:17:8:31 | [b (line 3): true] call to method Return<String> | normal | Splitting.cs:8:17:8:31 | [b (line 3): true] call to method Return<String> |
 | Splitting.cs:20:22:20:30 | call to method Return<String> | normal | Splitting.cs:20:22:20:30 | call to method Return<String> |

csharp/ql/test/library-tests/expressions/ConstructorInitializers.expected

@@ -8,3 +8,24 @@
 | expressions.cs:481:20:481:22 | Num | expressions.cs:481:20:481:22 | call to constructor Object | file://:0:0:0:0 | Object |
 | expressions.cs:518:11:518:17 | ClassC1 | expressions.cs:518:11:518:17 | call to constructor Object | file://:0:0:0:0 | Object |
 | expressions.cs:520:11:520:17 | ClassC2 | expressions.cs:520:33:520:44 | call to constructor ClassC1 | expressions.cs:518:11:518:17 | ClassC1 |
+| file://:0:0:0:0 | Button | expressions.cs:227:18:227:23 | call to constructor Object | file://:0:0:0:0 | Object |
+| file://:0:0:0:0 | C | expressions.cs:207:11:207:11 | call to constructor Object | file://:0:0:0:0 | Object |
+| file://:0:0:0:0 | Contact | expressions.cs:372:18:372:24 | call to constructor Object | file://:0:0:0:0 | Object |
+| file://:0:0:0:0 | Digit | expressions.cs:306:19:306:23 | call to constructor ValueType | file://:0:0:0:0 | ValueType |
+| file://:0:0:0:0 | ExpressionDepth | expressions.cs:495:11:495:25 | call to constructor Object | file://:0:0:0:0 | Object |
+| file://:0:0:0:0 | FoldedLiterals | FoldedLiterals.cs:1:7:1:20 | call to constructor Object | file://:0:0:0:0 | Object |
+| file://:0:0:0:0 | MethodAccess | MethodAccess.cs:3:7:3:18 | call to constructor Object | file://:0:0:0:0 | Object |
+| file://:0:0:0:0 | MyInlineArray | expressions.cs:513:12:513:24 | call to constructor ValueType | file://:0:0:0:0 | ValueType |
+| file://:0:0:0:0 | OperatorCalls | expressions.cs:463:11:463:23 | call to constructor Object | file://:0:0:0:0 | Object |
+| file://:0:0:0:0 | Point | expressions.cs:341:18:341:22 | call to constructor Object | file://:0:0:0:0 | Object |
+| file://:0:0:0:0 | Qualifiers | Qualifiers.cs:3:7:3:16 | call to constructor Object | file://:0:0:0:0 | Object |
+| file://:0:0:0:0 | Rectangle | expressions.cs:351:18:351:26 | call to constructor Object | file://:0:0:0:0 | Object |
+| file://:0:0:0:0 | Rectangle2 | expressions.cs:361:18:361:27 | call to constructor Object | file://:0:0:0:0 | Object |
+| file://:0:0:0:0 | ReducedClass | ReducedExpression.cs:2:7:2:18 | call to constructor Object | file://:0:0:0:0 | Object |
+| file://:0:0:0:0 | TestConversionOperator | expressions.cs:330:11:330:32 | call to constructor Object | file://:0:0:0:0 | Object |
+| file://:0:0:0:0 | TestCreations | expressions.cs:383:18:383:30 | call to constructor Object | file://:0:0:0:0 | Object |
+| file://:0:0:0:0 | TestUnaryOperator | expressions.cs:292:11:292:27 | call to constructor Object | file://:0:0:0:0 | Object |
+| file://:0:0:0:0 | TupleExprs | expressions.cs:501:11:501:20 | call to constructor Object | file://:0:0:0:0 | Object |
+| file://:0:0:0:0 | X | expressions.cs:108:15:108:18 | call to constructor Object | file://:0:0:0:0 | Object |
+| file://:0:0:0:0 | X | expressions.cs:216:18:216:18 | call to constructor Object | file://:0:0:0:0 | Object |
+| file://:0:0:0:0 | Y | expressions.cs:104:15:104:21 | call to constructor Object | file://:0:0:0:0 | Object |

csharp/ql/test/library-tests/exprorstmtparent/Callable.expected

@@ -1,3 +1,5 @@
+| A.cs:4:7:4:8 | C1 | A.cs:4:7:4:8 | {...} |
+| A.cs:4:7:4:8 | C1 | B.cs:1:7:1:8 | {...} |
 | A.cs:6:22:6:31 | get_P1 | A.cs:6:22:6:31 | throw ... |
 | A.cs:6:22:6:31 | get_P1 | B.cs:3:22:3:22 | 0 |
 | A.cs:7:21:7:23 | get_P2 | A.cs:7:25:7:39 | {...} |
@@ -23,11 +25,17 @@
 | A.cs:22:6:22:7 | ~C2 | B.cs:20:11:20:25 | {...} |
 | A.cs:23:28:23:35 | implicit conversion | A.cs:23:50:23:53 | null |
 | A.cs:23:28:23:35 | implicit conversion | B.cs:21:50:21:59 | throw ... |
+| A.cs:28:7:28:8 | C3 | A.cs:28:7:28:8 | {...} |
+| A.cs:28:7:28:8 | C3 | B.cs:25:7:25:8 | {...} |
 | A.cs:30:21:30:23 | get_P3 | A.cs:30:28:30:37 | throw ... |
+| A.cs:34:15:34:16 | C4 | A.cs:34:15:34:16 | {...} |
+| A.cs:34:15:34:16 | C4 | C.cs:1:15:1:16 | {...} |
 | A.cs:36:9:36:10 | M1 | A.cs:36:14:36:28 | {...} |
 | A.cs:36:9:36:10 | M1 | B.cs:32:17:32:17 | 0 |
 | A.cs:37:9:37:10 | M2 | A.cs:37:14:37:28 | {...} |
 | A.cs:37:9:37:10 | M2 | C.cs:3:17:3:17 | 0 |
+| B.cs:1:7:1:8 | C1 | A.cs:4:7:4:8 | {...} |
+| B.cs:1:7:1:8 | C1 | B.cs:1:7:1:8 | {...} |
 | B.cs:3:22:3:22 | get_P1 | A.cs:6:22:6:31 | throw ... |
 | B.cs:3:22:3:22 | get_P1 | B.cs:3:22:3:22 | 0 |
 | B.cs:4:21:4:23 | get_P2 | A.cs:7:25:7:39 | {...} |
@@ -53,8 +61,12 @@
 | B.cs:20:6:20:7 | ~C2 | B.cs:20:11:20:25 | {...} |
 | B.cs:21:28:21:35 | implicit conversion | A.cs:23:50:23:53 | null |
 | B.cs:21:28:21:35 | implicit conversion | B.cs:21:50:21:59 | throw ... |
+| B.cs:25:7:25:8 | C3 | A.cs:28:7:28:8 | {...} |
+| B.cs:25:7:25:8 | C3 | B.cs:25:7:25:8 | {...} |
 | B.cs:27:21:27:23 | get_P3 | A.cs:30:28:30:37 | throw ... |
 | B.cs:32:9:32:10 | M1 | A.cs:36:14:36:28 | {...} |
 | B.cs:32:9:32:10 | M1 | B.cs:32:17:32:17 | 0 |
+| C.cs:1:15:1:16 | C4 | A.cs:34:15:34:16 | {...} |
+| C.cs:1:15:1:16 | C4 | C.cs:1:15:1:16 | {...} |
 | C.cs:3:9:3:10 | M2 | A.cs:37:14:37:28 | {...} |
 | C.cs:3:9:3:10 | M2 | C.cs:3:17:3:17 | 0 |

csharp/ql/test/library-tests/goto/Goto1.expected

@@ -1,3 +1,7 @@
+| goto.cs:2:7:2:10 | call to constructor Object | goto.cs:2:7:2:10 | {...} | semmle.label | successor |
+| goto.cs:2:7:2:10 | enter Goto | goto.cs:2:7:2:10 | call to constructor Object | semmle.label | successor |
+| goto.cs:2:7:2:10 | exit Goto (normal) | goto.cs:2:7:2:10 | exit Goto | semmle.label | successor |
+| goto.cs:2:7:2:10 | {...} | goto.cs:2:7:2:10 | exit Goto (normal) | semmle.label | successor |
 | goto.cs:4:17:4:20 | enter Main | goto.cs:5:5:20:5 | {...} | semmle.label | successor |
 | goto.cs:4:17:4:20 | exit Main (normal) | goto.cs:4:17:4:20 | exit Main | semmle.label | successor |
 | goto.cs:5:5:20:5 | {...} | goto.cs:6:9:8:9 | {...} | semmle.label | successor |

csharp/ql/test/library-tests/nullable/NullableExpressions.expected

@@ -1,3 +1,4 @@
+| 1 | 14 | nullable.cs:1:14:1:21 | Nullable | nullable.cs:1:14:1:21 | call to constructor Object | Object |
 | 5 | 13 | nullable.cs:5:9:6:24 | if (...) ... | nullable.cs:5:13:5:21 | ... == ... | Boolean |
 | 5 | 13 | nullable.cs:5:13:5:21 | ... == ... | nullable.cs:5:13:5:13 | access to parameter x | Nullable<Int32> |
 | 5 | 18 | nullable.cs:5:13:5:21 | ... == ... | nullable.cs:5:18:5:21 | null | null |

csharp/ql/test/library-tests/standalone/controlflow/cfg.expected

@@ -1,3 +1,7 @@
+| ControlFlow.cs:3:7:3:9 | call to constructor Object | ControlFlow.cs:3:7:3:9 | {...} |
+| ControlFlow.cs:3:7:3:9 | enter Cfg | ControlFlow.cs:3:7:3:9 | call to constructor Object |
+| ControlFlow.cs:3:7:3:9 | exit Cfg (normal) | ControlFlow.cs:3:7:3:9 | exit Cfg |
+| ControlFlow.cs:3:7:3:9 | {...} | ControlFlow.cs:3:7:3:9 | exit Cfg (normal) |
 | ControlFlow.cs:5:10:5:10 | enter F | ControlFlow.cs:6:5:11:5 | {...} |
 | ControlFlow.cs:5:10:5:10 | exit F (normal) | ControlFlow.cs:5:10:5:10 | exit F |
 | ControlFlow.cs:6:5:11:5 | {...} | ControlFlow.cs:7:9:7:34 | ... ...; |

csharp/ql/test/library-tests/standalone/errorrecovery/DiagnosticsAndErrors.expected

@@ -37,6 +37,7 @@ extractorMessages
 | errors.cs:22:31:22:40 | Unable to resolve target for call. (Compilation error?) |
 | errors.cs:22:38:22:39 | Failed to determine type |
 | errors.cs:55:20:55:20 | Failed to determine type |
+| errors.cs:79:11:79:12 | Unable to resolve implicit constructor initializer call |
 | errors.cs:91:45:91:45 | Failed to determine type |
 | errors.cs:91:45:91:45 | Failed to resolve name |
 | errors.cs:92:45:92:45 | Failed to determine type |