Skip to content

Commit a9e07a8

Browse files
committed
Downgrade IncorrectIntegerConversionQuery precision to high
`very-high` implies near 0 false positives and we have run into a number and an entire class Signed-off-by: Josh Soref <[email protected]>
1 parent 590e93d commit a9e07a8

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

go/ql/src/Security/CWE-681/IncorrectIntegerConversionQuery.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
* @tags security
1111
* external/cwe/cwe-190
1212
* external/cwe/cwe-681
13-
* @precision very-high
13+
* @precision high
1414
*/
1515

1616
import go
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
category: queryMetadata
3+
---
4+
* The precision of the `go/incorrect-integer-conversion-query` query was decreased from `very-high` to `high`, since there is at least one known class of false positives involving dynamic bounds checking.

0 commit comments

Comments
 (0)