Skip to content

Commit aa0db14

Browse files
committed
Swift: Simplify the QL a bit further.
1 parent d0f214a commit aa0db14

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

swift/ql/lib/codeql/swift/security/XXEExtensions.qll

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -172,20 +172,12 @@ private class Libxml2XxeSink extends XxeSink {
172172
Libxml2XxeSink() {
173173
exists(Libxml2ParseCall c, Libxml2BadOption opt |
174174
this.asExpr() = c.getXml() and
175-
lib2xmlOptionLocalTaintStep*(DataFlow::exprNode(opt.getAnAccess()),
175+
TaintTracking::localTaintStep*(DataFlow::exprNode(opt.getAnAccess()),
176176
DataFlow::exprNode(c.getOptions()))
177177
)
178178
}
179179
}
180180

181-
/**
182-
* Holds if taint can flow from `source` to `sink` in one local step,
183-
* including bitwise operations, accesses to `.rawValue`, and casts to `Int32`.
184-
*/
185-
private predicate lib2xmlOptionLocalTaintStep(DataFlow::Node source, DataFlow::Node sink) {
186-
TaintTracking::localTaintStep(source, sink)
187-
}
188-
189181
/**
190182
* A sink defined in a CSV model.
191183
*/

0 commit comments

Comments
 (0)