C++: Respond to PR reviews.

MathiasVP · MathiasVP · commit b01a45f7be74 · 2023-02-14T09:51:48.000Z
diff --git a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll
@@ -119,7 +119,7 @@ abstract class InstructionNode0 extends Node0Impl {
     result = instr.getOpcode().toString()
   }
 
-  final override predicate isGLValue() { instr.isGLValue() }
+  final override predicate isGLValue() { exists(getInstructionType(instr, true)) }
 }
 
 /**
@@ -160,7 +160,7 @@ abstract class OperandNode0 extends Node0Impl {
 
   override string toStringImpl() { result = op.toString() }
 
-  final override predicate isGLValue() { op.isGLValue() }
+  final override predicate isGLValue() { exists(getOperandType(op, true)) }
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ abstract class InstructionNode0 extends Node0Impl {`
`119`	`119`	`result = instr.getOpcode().toString()`
`120`	`120`	`}`
`121`	`121`
`122`		`- final override predicate isGLValue() { instr.isGLValue() }`
	`122`	`+ final override predicate isGLValue() { exists(getInstructionType(instr, true)) }`
`123`	`123`	`}`
`124`	`124`
`125`	`125`	`/**`
`@@ -160,7 +160,7 @@ abstract class OperandNode0 extends Node0Impl {`
`160`	`160`
`161`	`161`	`override string toStringImpl() { result = op.toString() }`
`162`	`162`
`163`		`- final override predicate isGLValue() { op.isGLValue() }`
	`163`	`+ final override predicate isGLValue() { exists(getOperandType(op, true)) }`
`164`	`164`	`}`
`165`	`165`
`166`	`166`	`/**`