Skip to content

Commit b451ada

Browse files
committed
Two small QLDoc improvements
1 parent 896a3c6 commit b451ada

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

go/ql/lib/semmle/go/security/IncorrectIntegerConversionLib.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ private class MaxValueState extends TMaxValueState {
235235
predicate architectureBitSizeUnknown() { this.architectureBitSize().isUnknown() }
236236

237237
/**
238-
* Gets the bitsize we should use for a sink.
238+
* Gets the bitsize we should use for a sink of type `uint`.
239239
*
240240
* If the architecture bit size is known, then we should use that. Otherwise,
241241
* we should use 32 bits, because that will find results that only exist on
@@ -344,7 +344,7 @@ class UpperBoundCheckGuard extends DataFlow::RelationalComparisonNode {
344344
* _ = uint16(parsed)
345345
* }
346346
* ```
347-
* `parsed < math.MaxInt16` is an `UpperBoundCheckGuard` and `uint16(parsed)`
347+
* `parsed <= math.MaxInt16` is an `UpperBoundCheckGuard` and `uint16(parsed)`
348348
* is an `UpperBoundCheck` that would be a barrier for flow states with bit
349349
* size greater than 15 and would transform them to a flow state with bit size
350350
* 15 and the same architecture bit size.

0 commit comments

Comments
 (0)