Skip to content

Commit b63d518

Browse files
committed
Dataflow: Minor perf tweak.
1 parent b456ba2 commit b63d518

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1459,8 +1459,7 @@ module MakeImpl<InputSig Lang> {
14591459
pragma[nomagic]
14601460
private predicate fwdFlowInCand(
14611461
DataFlowCall call, DataFlowCallable inner, ParamNodeEx p, FlowState state, Cc outercc,
1462-
CcCall innercc, ParamNodeOption summaryCtx, TypOption argT, ApOption argAp, Typ t, Ap ap,
1463-
ApApprox apa
1462+
ParamNodeOption summaryCtx, TypOption argT, ApOption argAp, Typ t, Ap ap, ApApprox apa
14641463
) {
14651464
exists(ArgNodeEx arg, boolean allowsFieldFlow |
14661465
fwdFlow(arg, state, outercc, summaryCtx, argT, argAp, t, ap, apa) and
@@ -1471,7 +1470,6 @@ module MakeImpl<InputSig Lang> {
14711470
) and
14721471
flowIntoCallApaInlineLate(call, inner, arg, p, allowsFieldFlow, apa)
14731472
|
1474-
innercc = getCallContextCall(call, inner) and
14751473
if allowsFieldFlow = false then ap instanceof ApNil else any()
14761474
)
14771475
}
@@ -1482,9 +1480,9 @@ module MakeImpl<InputSig Lang> {
14821480
ParamNodeOption summaryCtx, TypOption argT, ApOption argAp, Typ t, Ap ap, ApApprox apa
14831481
) {
14841482
exists(DataFlowCallable inner, boolean cc |
1485-
fwdFlowInCand(call, inner, p, state, outercc, innercc, summaryCtx, argT, argAp, t, ap,
1486-
apa) and
1483+
fwdFlowInCand(call, inner, p, state, outercc, summaryCtx, argT, argAp, t, ap, apa) and
14871484
FwdTypeFlow::typeFlowValidEdgeIn(call, inner, cc) and
1485+
innercc = getCallContextCall(call, inner) and
14881486
if outercc instanceof CcCall then cc = true else cc = false
14891487
)
14901488
}

0 commit comments

Comments
 (0)