Skip to content

Commit b70f7e2

Browse files
committed
PS: Fix missing toString and accept test changes.
1 parent 7d72683 commit b70f7e2

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

powershell/ql/lib/semmle/code/powershell/ast/internal/MemberExpr.qll

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,12 @@ class MemberExpr extends Expr, TMemberExpr {
3737

3838
predicate isStatic() { getRawAst(this).(Raw::MemberExpr).isStatic() }
3939

40-
final override string toString() { result = this.getMemberName() }
40+
final override string toString() {
41+
result = this.getMemberName()
42+
or
43+
not exists(this.getMemberName()) and
44+
result = "..."
45+
}
4146

4247
predicate isExplicitWrite(Ast assignment) {
4348
explicitAssignment(getRawAst(this), getRawAst(assignment))

powershell/ql/test/library-tests/ast/Expressions/expressions.expected

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ cmdExpr
55
| BinaryExpression.ps1:4:1:4:7 | [Stmt] result | BinaryExpression.ps1:4:1:4:7 | result |
66
| ExpandableString.ps1:1:1:1:39 | [Stmt] Date: $([DateTime]::Now)\nName: $name | ExpandableString.ps1:1:1:1:39 | Date: $([DateTime]::Now)\nName: $name |
77
| ExpandableString.ps1:1:23:1:37 | [Stmt] Now | ExpandableString.ps1:1:23:1:37 | Now |
8-
| MemberExpression.ps1:2:1:2:14 | (no string representation) | MemberExpression.ps1:2:1:2:14 | (no string representation) |
8+
| MemberExpression.ps1:2:1:2:14 | [Stmt] ... | MemberExpression.ps1:2:1:2:14 | ... |
99
| SubExpression.ps1:1:1:1:23 | [Stmt] Call to AddDays | SubExpression.ps1:1:1:1:23 | Call to AddDays |
1010
| SubExpression.ps1:1:3:1:10 | [Stmt] Call to Get-Date | SubExpression.ps1:1:3:1:10 | Call to Get-Date |
1111
| SubExpression.ps1:2:1:2:21 | [Stmt] Call to AddDays | SubExpression.ps1:2:1:2:21 | Call to AddDays |
@@ -16,4 +16,4 @@ expandableString
1616
| ExpandableString.ps1:1:1:1:39 | Date: $([DateTime]::Now)\nName: $name | 1 | ExpandableString.ps1:1:21:1:38 | $(...) |
1717
memberExpr
1818
| ExpandableString.ps1:1:23:1:37 | Now | ExpandableString.ps1:1:23:1:32 | DateTime |
19-
| MemberExpression.ps1:2:1:2:14 | (no string representation) | MemberExpression.ps1:2:1:2:10 | DateTime |
19+
| MemberExpression.ps1:2:1:2:14 | ... | MemberExpression.ps1:2:1:2:10 | DateTime |

0 commit comments

Comments
 (0)