Swift: Use camelCase in KeyPathComponent predicates.

Author: sashabu

swift/ql/lib/codeql/swift/elements/KeyPathComponent.qll

@@ -4,35 +4,35 @@ class KeyPathComponent extends Generated::KeyPathComponent {
   /**
    * Property access like `.bar` in `\Foo.bar`.
    */
-  predicate is_property() { getKind() = 3 }
+  predicate isProperty() { getKind() = 3 }
 
   /**
    * Array or dictionary subscript like `[1]` or `["a", "b"]`.
    */
-  predicate is_subscript() { getKind() = 4 }
+  predicate isSubscript() { getKind() = 4 }
 
   /**
    * Optional forcing `!`.
    */
-  predicate is_optional_forcing() { getKind() = 5 }
+  predicate isOptionalForcing() { getKind() = 5 }
 
   /**
    * Optional chaining `?`.
    */
-  predicate is_optional_chaining() { getKind() = 6 }
+  predicate isOptionalChaining() { getKind() = 6 }
 
   /**
    * Implicit optional wrapping component inserted by the compiler when an optional chain ends in a non-optional value.
    */
-  predicate is_optional_wrapping() { getKind() = 7 }
+  predicate isOptionalWrapping() { getKind() = 7 }
 
   /**
    * Reference to the entire object; the `self` in `\Foo.self`.
    */
-  predicate is_self() { getKind() = 8 }
+  predicate isSelf() { getKind() = 8 }
 
   /**
    * Tuple indexing like `.1`.
    */
-  predicate is_tuple_indexing() { getKind() = 9 }
+  predicate isTupleIndexing() { getKind() = 9 }
 }

swift/ql/test/library-tests/elements/KeyPathComponent/KindAccessors.ql

@@ -7,12 +7,12 @@ from
 where
   toBeTested(x) and
   not x.isUnknown() and
-  (if x.is_property() then property = "property" else property = "") and
-  (if x.is_subscript() then subscript = "subscript" else subscript = "") and
-  (if x.is_optional_forcing() then opt_forcing = "optional forcing" else opt_forcing = "") and
-  (if x.is_optional_chaining() then opt_chaining = "optional chaining" else opt_chaining = "") and
-  (if x.is_optional_wrapping() then opt_wrapping = "optional wrapping" else opt_wrapping = "") and
-  (if x.is_self() then self = "self" else self = "") and
-  if x.is_tuple_indexing() then tuple_indexing = "tuple indexing" else tuple_indexing = ""
+  (if x.isProperty() then property = "property" else property = "") and
+  (if x.isSubscript() then subscript = "subscript" else subscript = "") and
+  (if x.isOptionalForcing() then opt_forcing = "optional forcing" else opt_forcing = "") and
+  (if x.isOptionalChaining() then opt_chaining = "optional chaining" else opt_chaining = "") and
+  (if x.isOptionalWrapping() then opt_wrapping = "optional wrapping" else opt_wrapping = "") and
+  (if x.isSelf() then self = "self" else self = "") and
+  if x.isTupleIndexing() then tuple_indexing = "tuple indexing" else tuple_indexing = ""
 select x, "getKind:", x.getKind(), property, subscript, opt_forcing, opt_chaining, opt_wrapping,
   self, tuple_indexing