Skip to content

Commit b9200c9

Browse files
committed
C++: Address review comments
1 parent 3dfe0ad commit b9200c9

File tree

7 files changed

+9
-9
lines changed

7 files changed

+9
-9
lines changed

cpp/ql/lib/semmle/code/cpp/dataflow/new/DataFlow.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
* results than the AST-based library in most scenarios.
99
*
1010
* Unless configured otherwise, _flow_ means that the exact value of
11-
* the source may reach the sink. We do not track flow across pointer
12-
* dereferences or array indexing.
11+
* the source may reach the sink. To track flow where the exact value
12+
* may not be preserved, import `semmle.code.cpp.dataflow.new.TaintTracking`.
1313
*
1414
* To use global (interprocedural) data flow, extend the class
1515
* `DataFlow::Configuration` as documented on that class. To use local

cpp/ql/lib/semmle/code/cpp/dataflow/new/DataFlow2.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* `DataFlow2::Configuration`, a `DataFlow3::Configuration`, or a
77
* `DataFlow4::Configuration`.
88
*
9-
* See `semmle.code.cpp.ir.dataflow.DataFlow` for the full documentation.
9+
* See `semmle.code.cpp.dataflow.new.DataFlow` for the full documentation.
1010
*/
1111

1212
import cpp

cpp/ql/lib/semmle/code/cpp/dataflow/new/DataFlow3.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* `DataFlow2::Configuration`, a `DataFlow3::Configuration`, or a
77
* `DataFlow4::Configuration`.
88
*
9-
* See `semmle.code.cpp.ir.dataflow.DataFlow` for the full documentation.
9+
* See `semmle.code.cpp.dataflow.new.DataFlow` for the full documentation.
1010
*/
1111

1212
import cpp

cpp/ql/lib/semmle/code/cpp/dataflow/new/DataFlow4.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* `DataFlow2::Configuration`, a `DataFlow3::Configuration`, or a
77
* `DataFlow4::Configuration`.
88
*
9-
* See `semmle.code.cpp.ir.dataflow.DataFlow` for the full documentation.
9+
* See `semmle.code.cpp.dataflow.new.DataFlow` for the full documentation.
1010
*/
1111

1212
import cpp

cpp/ql/lib/semmle/code/cpp/dataflow/new/TaintTracking2.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
* `TaintTracking::Configuration` class extends `DataFlow::Configuration`, and
99
* `TaintTracking2::Configuration` extends `DataFlow2::Configuration`.
1010
*
11-
* See `semmle.code.cpp.ir.dataflow.TaintTracking` for the full documentation.
11+
* See `semmle.code.cpp.dataflow.new.TaintTracking` for the full documentation.
1212
*/
1313

1414
/**

cpp/ql/lib/semmle/code/cpp/dataflow/new/TaintTracking3.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
* `TaintTracking::Configuration` class extends `DataFlow::Configuration`, and
99
* `TaintTracking2::Configuration` extends `DataFlow2::Configuration`.
1010
*
11-
* See `semmle.code.cpp.ir.dataflow.TaintTracking` for the full documentation.
11+
* See `semmle.code.cpp.dataflow.new.TaintTracking` for the full documentation.
1212
*/
1313

1414
/**

cpp/ql/lib/semmle/code/cpp/ir/dataflow/DataFlow.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
* results than the AST-based library in most scenarios.
99
*
1010
* Unless configured otherwise, _flow_ means that the exact value of
11-
* the source may reach the sink. We do not track flow across pointer
12-
* dereferences or array indexing.
11+
* the source may reach the sink. To track flow where the exact value
12+
* may not be preserved, import `semmle.code.cpp.ir.dataflow.TaintTracking`.
1313
*
1414
* To use global (interprocedural) data flow, extend the class
1515
* `DataFlow::Configuration` as documented on that class. To use local

0 commit comments

Comments
 (0)