Skip to content

Commit bbe5f5e

Browse files
committed
Swift: HACK -> TODO.
1 parent 4dcd3be commit bbe5f5e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

swift/ql/lib/codeql/swift/dataflow/internal/DataFlowPrivate.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -683,14 +683,14 @@ predicate storeStep(Node node1, ContentSet c, Node node2) {
683683
// i.e. from `f(x)` where `x: T` into `f(.some(x))` where the context `f` expects a `T?`.
684684
exists(InjectIntoOptionalExpr e |
685685
e.convertsFrom(node1.asExpr()) and
686-
node2 = node1 and // HACK: we should ideally have a separate Node case for the (hidden) InjectIntoOptionalExpr
686+
node2 = node1 and // TODO: we should ideally have a separate Node case for the (hidden) InjectIntoOptionalExpr
687687
c instanceof OptionalSomeContentSet
688688
)
689689
or
690690
// creation of an optional by returning from a failable initializer (`init?`)
691691
exists(Initializer init |
692692
node1.asExpr().(CallExpr).getStaticTarget() = init and
693-
node2 = node1 and // HACK: again, we should ideally have a separate Node case here, and not reuse the CallExpr
693+
node2 = node1 and // TODO: again, we should ideally have a separate Node case here, and not reuse the CallExpr
694694
c instanceof OptionalSomeContentSet and
695695
init.isFailable()
696696
)

0 commit comments

Comments
 (0)