Skip to content

Commit c92e8dc

Browse files
geoffw0felicitymay
andauthored
Apply suggestions from code review
Co-authored-by: Felicity Chapman <[email protected]>
1 parent f1fb3e1 commit c92e8dc

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

docs/codeql/codeql-language-guides/analyzing-data-flow-in-swift.rst

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,12 @@ The ``Node`` class has a number of useful subclasses, such as ``ExprNode`` for e
2929
3030
class Node {
3131
/**
32-
* Gets this node's underlying expression, if any.
32+
* Gets the expression that corresponds to this node, if any.
3333
*/
3434
Expr asExpr() { ... }
3535
3636
/**
37-
* Gets this data flow node's corresponding control flow node.
37+
* Gets the control flow node that corresponds to this data flow node.
3838
*/
3939
ControlFlowNode getCfgNode() { ... }
4040
@@ -203,7 +203,7 @@ Using global taint tracking
203203

204204
Global taint tracking is to global data flow what local taint tracking is to local data flow.
205205
That is, global taint tracking extends global data flow with additional non-value-preserving steps.
206-
The global taint tracking library uses the same configuration module as the global data flow library but taint flow analysis is performed with ``TaintTracking::Global``:
206+
The global taint tracking library uses the same configuration module as the global data flow library. You can perform taint flow analysis using ``TaintTracking::Global``:
207207

208208
.. code-block:: ql
209209
@@ -216,7 +216,7 @@ The global taint tracking library uses the same configuration module as the glob
216216
Predefined sources
217217
~~~~~~~~~~~~~~~~~~
218218

219-
The data flow library module ``codeql.swift.dataflow.FlowSources`` contains a number of predefined sources, providing a good starting point for defining data flow and taint flow based security queries.
219+
The data flow library module ``codeql.swift.dataflow.FlowSources`` contains a number of predefined sources that you can use to write security queries to track data flow and taint flow.
220220

221221
- The class ``RemoteFlowSource`` represents data flow from remote network inputs and from other applications.
222222
- The class ``LocalFlowSource`` represents data flow from local user input.
@@ -229,7 +229,7 @@ The following global taint-tracking query finds places where a string literal is
229229
- Since this is a taint-tracking query, the ``TaintTracking::Global`` module is used.
230230
- The ``isSource`` predicate defines sources as any ``StringLiteralExpr``.
231231
- The ``isSink`` predicate defines sinks as arguments to a ``CallExpr`` called "password".
232-
- The sources and sinks may need tuning to a particular use, for example if passwords are represented by a type other than ``String`` or passed in arguments of a different name than "password".
232+
- The sources and sinks may need tuning to a particular use, for example, if passwords are represented by a type other than ``String`` or passed in arguments of a different name than "password".
233233

234234
.. code-block:: ql
235235

0 commit comments

Comments
 (0)