Skip to content

Commit cd3b519

Browse files
geoffw0mchammer01
andauthored
Apply suggestions from code review
Co-authored-by: mc <[email protected]>
1 parent 75c5d16 commit cd3b519

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

swift/ql/src/queries/Security/CWE-116/BadTagFilter.qhelp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,15 @@ the function, and <code>alert(1)</code> will be executed by a browser if the str
3838
</p>
3939

4040
<p>
41-
Other corner cases include that HTML comments can end with <code>--!&gt;</code>,
42-
and that HTML tag names can contain upper case characters.
41+
Other corner cases include HTML comments ending with <code>--!&gt;</code>,
42+
and HTML tag names containing uppercase characters.
4343
</p>
4444
</example>
4545

4646
<references>
4747
<li>Securitum: <a href="https://research.securitum.com/the-curious-case-of-copy-paste/">The Curious Case of Copy &amp; Paste</a>.</li>
4848
<li>stackoverflow.com: <a href="https://stackoverflow.com/questions/1732348/regex-match-open-tags-except-xhtml-self-contained-tags#answer-1732454">You can't parse [X]HTML with regex</a>.</li>
4949
<li>HTML Standard: <a href="https://html.spec.whatwg.org/multipage/parsing.html#comment-end-bang-state">Comment end bang state</a>.</li>
50-
<li>stackoverflow.com: <a href="https://stackoverflow.com/questions/25559999/why-arent-browsers-strict-about-html">Why aren't browsers strict about HTML?</a>.</li>
50+
<li>stackoverflow.com: <a href="https://stackoverflow.com/questions/25559999/why-arent-browsers-strict-about-html">Why aren't browsers strict about HTML?</a></li>
5151
</references>
5252
</qhelp>

swift/ql/src/queries/Security/CWE-116/BadTagFilter.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/**
22
* @name Bad HTML filtering regexp
3-
* @description Matching HTML tags using regular expressions is hard to do right, and can easily lead to security issues.
3+
* @description Matching HTML tags using regular expressions is hard to do right, and can lead to security issues.
44
* @kind problem
55
* @problem.severity warning
66
* @security-severity 7.8

0 commit comments

Comments
 (0)