Skip to content

Commit d30b736

Browse files
committed
Move check for EmitNewerGoVersionNeeded diagnostic
This should only be done when --identify-environment has not been passed
1 parent afb6923 commit d30b736

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

go/extractor/cli/go-autobuilder/go-autobuilder.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -282,10 +282,6 @@ func tryReadGoDirective(depMode DependencyInstallerMode) (string, bool) {
282282
found = true
283283
if len(matches) > 1 {
284284
version = string(matches[1])
285-
semverVersion := "v" + version
286-
if semver.Compare(semverVersion, getEnvGoSemVer()) >= 0 {
287-
diagnostics.EmitNewerGoVersionNeeded()
288-
}
289285
}
290286
}
291287
}
@@ -672,7 +668,11 @@ func installDependenciesAndBuild() {
672668
os.Setenv("GO111MODULE", "auto")
673669
}
674670

675-
_, goModVersionFound := tryReadGoDirective(depMode)
671+
goModVersion, goModVersionFound := tryReadGoDirective(depMode)
672+
673+
if semver.Compare("v"+goModVersion, getEnvGoSemVer()) >= 0 {
674+
diagnostics.EmitNewerGoVersionNeeded()
675+
}
676676

677677
modMode := getModMode(depMode)
678678
modMode = fixGoVendorIssues(modMode, depMode, goModVersionFound)

0 commit comments

Comments
 (0)