Skip to content

Commit d31700c

Browse files
owen-mcowen-mc
committed
Accept changes in models in .expected files
1 parent dfd8e7d commit d31700c

35 files changed

+93
-93
lines changed

‎go/ql/test/experimental/CWE-522-DecompressionBombs/DecompressionBombs.expected

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -233,10 +233,10 @@ edges
233233
models
234234
| 1 | Source: net/http; Request; true; Body; ; ; ; remote; manual |
235235
| 2 | Source: net/http; Request; true; FormValue; ; ; ReturnValue; remote; manual |
236-
| 3 | Summary: archive/tar; ; false; NewReader; ; ; Argument[0]; ReturnValue; taint; manual |
236+
| 3 | Summary: archive/tar; ; true; NewReader; ; ; Argument[0]; ReturnValue; taint; manual |
237237
| 4 | Summary: archive/zip; File; true; Open; ; ; Argument[receiver]; ReturnValue[0]; taint; manual |
238-
| 5 | Summary: bytes; ; false; NewReader; ; ; Argument[0]; ReturnValue; taint; manual |
239-
| 6 | Summary: io; ; false; ReadAll; ; ; Argument[0]; ReturnValue[0]; taint; manual |
238+
| 5 | Summary: bytes; ; true; NewReader; ; ; Argument[0]; ReturnValue; taint; manual |
239+
| 6 | Summary: io; ; true; ReadAll; ; ; Argument[0]; ReturnValue[0]; taint; manual |
240240
nodes
241241
| test.go:59:16:59:44 | call to FormValue | semmle.label | call to FormValue |
242242
| test.go:60:15:60:26 | selection of Body | semmle.label | selection of Body |

‎go/ql/test/experimental/CWE-79/HTMLTemplateEscapingPassthrough.expected

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ edges
3535
| HTMLTemplateEscapingPassthrough.go:91:64:91:66 | src | HTMLTemplateEscapingPassthrough.go:91:38:91:67 | call to HTMLEscapeString | provenance | MaD:2 |
3636
models
3737
| 1 | Source: net/http; Request; true; UserAgent; ; ; ReturnValue; remote; manual |
38-
| 2 | Summary: html/template; ; false; HTMLEscapeString; ; ; Argument[0]; ReturnValue; taint; manual |
38+
| 2 | Summary: html/template; ; true; HTMLEscapeString; ; ; Argument[0]; ReturnValue; taint; manual |
3939
nodes
4040
| HTMLTemplateEscapingPassthrough.go:29:12:29:41 | type conversion | semmle.label | type conversion |
4141
| HTMLTemplateEscapingPassthrough.go:29:26:29:40 | call to UserAgent | semmle.label | call to UserAgent |

‎go/ql/test/experimental/CWE-918/SSRF.expected

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,12 +69,12 @@ models
6969
| 7 | Source: net/http; Request; true; FormValue; ; ; ReturnValue; remote; manual |
7070
| 8 | Source: net/http; Request; true; Referer; ; ; ReturnValue; remote; manual |
7171
| 9 | Source: net/http; Request; true; URL; ; ; ; remote; manual |
72-
| 10 | Summary: encoding/json; ; false; Unmarshal; ; ; Argument[0]; Argument[1]; taint; manual |
72+
| 10 | Summary: encoding/json; ; true; Unmarshal; ; ; Argument[0]; Argument[1]; taint; manual |
7373
| 11 | Summary: fmt; ; true; Sprintf; ; ; Argument[1].ArrayElement; ReturnValue; taint; manual |
74-
| 12 | Summary: io/ioutil; ; false; ReadAll; ; ; Argument[0]; ReturnValue[0]; taint; manual |
74+
| 12 | Summary: io/ioutil; ; true; ReadAll; ; ; Argument[0]; ReturnValue[0]; taint; manual |
7575
| 13 | Summary: net/url; URL; true; Query; ; ; Argument[receiver]; ReturnValue; taint; manual |
7676
| 14 | Summary: net/url; Values; true; Get; ; ; Argument[receiver]; ReturnValue; taint; manual |
77-
| 15 | Summary: strings; ; false; TrimPrefix; ; ; Argument[0]; ReturnValue; taint; manual |
77+
| 15 | Summary: strings; ; true; TrimPrefix; ; ; Argument[0]; ReturnValue; taint; manual |
7878
nodes
7979
| builtin.go:19:12:19:34 | call to FormValue | semmle.label | call to FormValue |
8080
| builtin.go:22:21:22:62 | ...+... | semmle.label | ...+... |

‎go/ql/test/library-tests/semmle/go/dataflow/HiddenNodes/test.expected

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
models
2-
| 1 | Summary: archive/tar; ; false; FileInfoHeader; ; ; Argument[0]; ReturnValue[0]; taint; manual |
2+
| 1 | Summary: archive/tar; ; true; FileInfoHeader; ; ; Argument[0]; ReturnValue[0]; taint; manual |
33
edges
44
| test.go:14:8:14:15 | call to source | test.go:15:34:15:35 | fi | provenance | |
55
| test.go:15:2:15:44 | ... := ...[0] | test.go:16:7:16:12 | header | provenance | |

‎go/ql/test/library-tests/semmle/go/dataflow/ThreatModels/threat-models-flowtest2.expected

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
models
2-
| 1 | Source: github.com/nonexistent/sources; ; false; ExecuteQuery; ; ; ReturnValue; database; manual |
2+
| 1 | Source: github.com/nonexistent/sources; ; true; ExecuteQuery; ; ; ReturnValue; database; manual |
33
| 2 | Source: net/http; Request; true; URL; ; ; ; remote; manual |
44
| 3 | Summary: net/url; URL; true; Query; ; ; Argument[receiver]; ReturnValue; taint; manual |
55
| 4 | Summary: net/url; Values; true; Get; ; ; Argument[receiver]; ReturnValue; taint; manual |

‎go/ql/test/library-tests/semmle/go/dataflow/ThreatModels/threat-models-flowtest3.expected

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
models
2-
| 1 | Source: github.com/nonexistent/sources; ; false; ExecuteQuery; ; ; ReturnValue; database; manual |
3-
| 2 | Source: github.com/nonexistent/sources; ; false; GetCliArg; ; ; ReturnValue; commandargs; manual |
4-
| 3 | Source: github.com/nonexistent/sources; ; false; ReadEnvironment; ; ; ReturnValue; environment; manual |
2+
| 1 | Source: github.com/nonexistent/sources; ; true; ExecuteQuery; ; ; ReturnValue; database; manual |
3+
| 2 | Source: github.com/nonexistent/sources; ; true; GetCliArg; ; ; ReturnValue; commandargs; manual |
4+
| 3 | Source: github.com/nonexistent/sources; ; true; ReadEnvironment; ; ; ReturnValue; environment; manual |
55
| 4 | Source: net/http; Request; true; URL; ; ; ; remote; manual |
66
| 5 | Summary: net/url; URL; true; Query; ; ; Argument[receiver]; ReturnValue; taint; manual |
77
| 6 | Summary: net/url; Values; true; Get; ; ; Argument[receiver]; ReturnValue; taint; manual |

‎go/ql/test/library-tests/semmle/go/dataflow/ThreatModels/threat-models-flowtest4.expected

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
models
2-
| 1 | Source: github.com/nonexistent/sources; ; false; ExecuteQuery; ; ; ReturnValue; database; manual |
3-
| 2 | Source: github.com/nonexistent/sources; ; false; GetCliArg; ; ; ReturnValue; commandargs; manual |
4-
| 3 | Source: github.com/nonexistent/sources; ; false; GetCustom; ; ; ReturnValue; custom; manual |
5-
| 4 | Source: github.com/nonexistent/sources; ; false; ReadEnvironment; ; ; ReturnValue; environment; manual |
2+
| 1 | Source: github.com/nonexistent/sources; ; true; ExecuteQuery; ; ; ReturnValue; database; manual |
3+
| 2 | Source: github.com/nonexistent/sources; ; true; GetCliArg; ; ; ReturnValue; commandargs; manual |
4+
| 3 | Source: github.com/nonexistent/sources; ; true; GetCustom; ; ; ReturnValue; custom; manual |
5+
| 4 | Source: github.com/nonexistent/sources; ; true; ReadEnvironment; ; ; ReturnValue; environment; manual |
66
| 5 | Source: net/http; Request; true; URL; ; ; ; remote; manual |
77
| 6 | Summary: net/url; URL; true; Query; ; ; Argument[receiver]; ReturnValue; taint; manual |
88
| 7 | Summary: net/url; Values; true; Get; ; ; Argument[receiver]; ReturnValue; taint; manual |

‎go/ql/test/library-tests/semmle/go/dataflow/ThreatModels/threat-models-flowtest5.expected

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
models
2-
| 1 | Source: github.com/nonexistent/sources; ; false; GetCliArg; ; ; ReturnValue; commandargs; manual |
3-
| 2 | Source: github.com/nonexistent/sources; ; false; ReadEnvironment; ; ; ReturnValue; environment; manual |
2+
| 1 | Source: github.com/nonexistent/sources; ; true; GetCliArg; ; ; ReturnValue; commandargs; manual |
3+
| 2 | Source: github.com/nonexistent/sources; ; true; ReadEnvironment; ; ; ReturnValue; environment; manual |
44
| 3 | Source: net/http; Request; true; URL; ; ; ; remote; manual |
55
| 4 | Summary: net/url; URL; true; Query; ; ; Argument[receiver]; ReturnValue; taint; manual |
66
| 5 | Summary: net/url; Values; true; Get; ; ; Argument[receiver]; ReturnValue; taint; manual |

‎go/ql/test/library-tests/semmle/go/dataflow/ThreatModels/threat-models-flowtest6.expected

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
models
2-
| 1 | Source: github.com/nonexistent/sources; ; false; ExecuteQuery; ; ; ReturnValue; database; manual |
3-
| 2 | Source: github.com/nonexistent/sources; ; false; GetCliArg; ; ; ReturnValue; commandargs; manual |
2+
| 1 | Source: github.com/nonexistent/sources; ; true; ExecuteQuery; ; ; ReturnValue; database; manual |
3+
| 2 | Source: github.com/nonexistent/sources; ; true; GetCliArg; ; ; ReturnValue; commandargs; manual |
44
| 3 | Source: net/http; Request; true; URL; ; ; ; remote; manual |
55
| 4 | Summary: net/url; URL; true; Query; ; ; Argument[receiver]; ReturnValue; taint; manual |
66
| 5 | Summary: net/url; Values; true; Get; ; ; Argument[receiver]; ReturnValue; taint; manual |

‎go/ql/test/library-tests/semmle/go/frameworks/Beego/ReflectedXss.expected

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -176,26 +176,26 @@ models
176176
| 19 | Source: group:beego; Controller; true; Input; ; ; ReturnValue[0]; remote; manual |
177177
| 20 | Source: group:beego; Controller; true; ParseForm; ; ; Argument[0]; remote; manual |
178178
| 21 | Source: net/http; Request; true; Form; ; ; ; remote; manual |
179-
| 22 | Summary: group:beego-utils; ; false; SliceChunk; ; ; Argument[0]; ReturnValue; taint; manual |
180-
| 23 | Summary: group:beego-utils; ; false; SliceDiff; ; ; Argument[0]; ReturnValue; taint; manual |
181-
| 24 | Summary: group:beego-utils; ; false; SliceFilter; ; ; Argument[0]; ReturnValue; taint; manual |
182-
| 25 | Summary: group:beego-utils; ; false; SliceIntersect; ; ; Argument[0..1]; ReturnValue; taint; manual |
183-
| 26 | Summary: group:beego-utils; ; false; SliceMerge; ; ; Argument[0..1]; ReturnValue; taint; manual |
184-
| 27 | Summary: group:beego-utils; ; false; SlicePad; ; ; Argument[0..2]; ReturnValue; taint; manual |
185-
| 28 | Summary: group:beego-utils; ; false; SliceRand; ; ; Argument[0]; ReturnValue; taint; manual |
186-
| 29 | Summary: group:beego-utils; ; false; SliceReduce; ; ; Argument[0]; ReturnValue; taint; manual |
187-
| 30 | Summary: group:beego-utils; ; false; SliceShuffle; ; ; Argument[0]; ReturnValue; taint; manual |
188-
| 31 | Summary: group:beego-utils; ; false; SliceUnique; ; ; Argument[0]; ReturnValue; taint; manual |
179+
| 22 | Summary: group:beego-utils; ; true; SliceChunk; ; ; Argument[0]; ReturnValue; taint; manual |
180+
| 23 | Summary: group:beego-utils; ; true; SliceDiff; ; ; Argument[0]; ReturnValue; taint; manual |
181+
| 24 | Summary: group:beego-utils; ; true; SliceFilter; ; ; Argument[0]; ReturnValue; taint; manual |
182+
| 25 | Summary: group:beego-utils; ; true; SliceIntersect; ; ; Argument[0..1]; ReturnValue; taint; manual |
183+
| 26 | Summary: group:beego-utils; ; true; SliceMerge; ; ; Argument[0..1]; ReturnValue; taint; manual |
184+
| 27 | Summary: group:beego-utils; ; true; SlicePad; ; ; Argument[0..2]; ReturnValue; taint; manual |
185+
| 28 | Summary: group:beego-utils; ; true; SliceRand; ; ; Argument[0]; ReturnValue; taint; manual |
186+
| 29 | Summary: group:beego-utils; ; true; SliceReduce; ; ; Argument[0]; ReturnValue; taint; manual |
187+
| 30 | Summary: group:beego-utils; ; true; SliceShuffle; ; ; Argument[0]; ReturnValue; taint; manual |
188+
| 31 | Summary: group:beego-utils; ; true; SliceUnique; ; ; Argument[0]; ReturnValue; taint; manual |
189189
| 32 | Summary: group:beego-utils; BeeMap; true; Get; ; ; Argument[receiver]; ReturnValue; taint; manual |
190190
| 33 | Summary: group:beego-utils; BeeMap; true; Items; ; ; Argument[receiver]; ReturnValue; taint; manual |
191191
| 34 | Summary: group:beego-utils; BeeMap; true; Set; ; ; Argument[1]; Argument[receiver]; taint; manual |
192-
| 35 | Summary: group:beego; ; false; HTML2str; ; ; Argument[0]; ReturnValue; taint; manual |
193-
| 36 | Summary: group:beego; ; false; Htmlunquote; ; ; Argument[0]; ReturnValue; taint; manual |
194-
| 37 | Summary: group:beego; ; false; MapGet; ; ; Argument[0]; ReturnValue[0]; taint; manual |
195-
| 38 | Summary: group:beego; ; false; ParseForm; ; ; Argument[0]; Argument[1]; taint; manual |
196-
| 39 | Summary: group:beego; ; false; Str2html; ; ; Argument[0]; ReturnValue; taint; manual |
197-
| 40 | Summary: group:beego; ; false; Substr; ; ; Argument[0]; ReturnValue; taint; manual |
198-
| 41 | Summary: io/ioutil; ; false; ReadAll; ; ; Argument[0]; ReturnValue[0]; taint; manual |
192+
| 35 | Summary: group:beego; ; true; HTML2str; ; ; Argument[0]; ReturnValue; taint; manual |
193+
| 36 | Summary: group:beego; ; true; Htmlunquote; ; ; Argument[0]; ReturnValue; taint; manual |
194+
| 37 | Summary: group:beego; ; true; MapGet; ; ; Argument[0]; ReturnValue[0]; taint; manual |
195+
| 38 | Summary: group:beego; ; true; ParseForm; ; ; Argument[0]; Argument[1]; taint; manual |
196+
| 39 | Summary: group:beego; ; true; Str2html; ; ; Argument[0]; ReturnValue; taint; manual |
197+
| 40 | Summary: group:beego; ; true; Substr; ; ; Argument[0]; ReturnValue; taint; manual |
198+
| 41 | Summary: io/ioutil; ; true; ReadAll; ; ; Argument[0]; ReturnValue[0]; taint; manual |
199199
nodes
200200
| test.go:33:6:33:10 | definition of bound | semmle.label | definition of bound |
201201
| test.go:35:13:35:30 | type conversion | semmle.label | type conversion |

0 commit comments

Comments
 (0)