SSA: Inline predicate to simplify negation.

aschackmull · aschackmull · commit d6dc91d19163 · 2025-02-18T14:01:20.000+01:00
diff --git a/shared/ssa/codeql/ssa/Ssa.qll b/shared/ssa/codeql/ssa/Ssa.qll
@@ -388,7 +388,7 @@ module Make<LocationSig Location, InputSig<Location> Input> {
     private predicate liveThrough(BasicBlock idom, BasicBlock bb, SourceVariable v) {
       idom = getImmediateBasicBlockDominator(bb) and
       liveAtExit(bb, v) and
-      not ssaRef(bb, _, v, Def())
+      not any(Definition def).definesAt(v, bb, _)
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -388,7 +388,7 @@ module Make<LocationSig Location, InputSig<Location> Input> {`
`388`	`388`	`private predicate liveThrough(BasicBlock idom, BasicBlock bb, SourceVariable v) {`
`389`	`389`	`idom = getImmediateBasicBlockDominator(bb) and`
`390`	`390`	`liveAtExit(bb, v) and`
`391`		`- not ssaRef(bb, _, v, Def())`
	`391`	`+ not any(Definition def).definesAt(v, bb, _)`
`392`	`392`	`}`
`393`	`393`
`394`	`394`	`/**`