Filter out tests directories

ropwareJB · ropwareJB · commit db49d95e7720 · 2024-04-17T11:47:23.000-07:00
diff --git a/cpp/ql/src/Security/CWE/CWE-129/ImproperArrayIndexValidation.ql b/cpp/ql/src/Security/CWE/CWE-129/ImproperArrayIndexValidation.ql
@@ -68,7 +68,7 @@ predicate predictableInstruction(Instruction instr) {
 module ImproperArrayIndexValidationConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) {
     isFlowSource(source, _) and
-    not source.asExpr().getFile().getRelativePath().regexpMatch("/tests?/")
+    not source.getLocation().getFile().getRelativePath().regexpMatch("(.*/)?tests?/.*")
   }
 
   predicate isBarrier(DataFlow::Node node) {

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ predicate predictableInstruction(Instruction instr) {`
`68`	`68`	`module ImproperArrayIndexValidationConfig implements DataFlow::ConfigSig {`
`69`	`69`	`predicate isSource(DataFlow::Node source) {`
`70`	`70`	`isFlowSource(source, _) and`
`71`		`- not source.asExpr().getFile().getRelativePath().regexpMatch("/tests?/")`
	`71`	`+ not source.getLocation().getFile().getRelativePath().regexpMatch("(./)?tests?/.")`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`predicate isBarrier(DataFlow::Node node) {`