C#: Remove unnecessary isUnboundDeclaration predicates

koesie10 · koesie10 · commit dd7904969f02 · 2023-09-19T14:51:03.000+02:00
diff --git a/csharp/ql/src/utils/modeleditor/FetchApplicationModeMethods.ql b/csharp/ql/src/utils/modeleditor/FetchApplicationModeMethods.ql
@@ -12,7 +12,6 @@ private import ModelEditor
 
 class ExternalEndpoint extends Endpoint {
   ExternalEndpoint() {
-    this.isUnboundDeclaration() and
     this.fromLibrary()
   }
 }
diff --git a/csharp/ql/src/utils/modeleditor/ModelEditor.qll b/csharp/ql/src/utils/modeleditor/ModelEditor.qll
@@ -28,8 +28,7 @@ class Endpoint extends DotNet::Callable {
   Endpoint() {
     [this.(Modifiable), this.(Accessor).getDeclaration()].isEffectivelyPublic() and
     not isUninteresting(this) and
-    this.isUnboundDeclaration() and
-    this.getDeclaringType().isUnboundDeclaration()
+    this.isUnboundDeclaration()
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,6 @@ private import ModelEditor`
`12`	`12`
`13`	`13`	`class ExternalEndpoint extends Endpoint {`
`14`	`14`	`ExternalEndpoint() {`
`15`		`- this.isUnboundDeclaration() and`
`16`	`15`	`this.fromLibrary()`
`17`	`16`	`}`
`18`	`17`	`}`
Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,7 @@ class Endpoint extends DotNet::Callable {`
`28`	`28`	`Endpoint() {`
`29`	`29`	`[this.(Modifiable), this.(Accessor).getDeclaration()].isEffectivelyPublic() and`
`30`	`30`	`not isUninteresting(this) and`
`31`		`- this.isUnboundDeclaration() and`
`32`		`- this.getDeclaringType().isUnboundDeclaration()`
	`31`	`+ this.isUnboundDeclaration()`
`33`	`32`	`}`
`34`	`33`
`35`	`34`	`/**`