Swift: Remove redundant code.

geoffw0 · geoffw0 · commit e225ea6bef99 · 2023-10-05T11:14:54.000+01:00
diff --git a/swift/ql/lib/codeql/swift/regex/Regex.qll b/swift/ql/lib/codeql/swift/regex/Regex.qll
@@ -476,12 +476,6 @@ private class NSStringCompareOptionsPotentialRegexEval extends PotentialRegexEva
   override predicate doesEvaluate() {
     // check there is flow from a `NSString.CompareOptions.regularExpression` value to an `options` argument;
     // if there isn't, the input won't be interpretted as a regular expression.
-    exists(MemberRefExpr sourceValue |
-      sourceValue
-          .getMember()
-          .(FieldDecl)
-          .hasQualifiedName("NSString.CompareOptions", "regularExpression") and
-      RegexEnableFlagFlow::flow(DataFlow::exprNode(sourceValue), optionsInput)
-    )
+    RegexEnableFlagFlow::flow(_, optionsInput)
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -476,12 +476,6 @@ private class NSStringCompareOptionsPotentialRegexEval extends PotentialRegexEva`
`476`	`476`	`override predicate doesEvaluate() {`
`477`	`477`	// check there is flow from a `NSString.CompareOptions.regularExpression` value to an `options` argument;
`478`	`478`	`// if there isn't, the input won't be interpretted as a regular expression.`
`479`		`- exists(MemberRefExpr sourceValue \|`
`480`		`- sourceValue`
`481`		`- .getMember()`
`482`		`- .(FieldDecl)`
`483`		`- .hasQualifiedName("NSString.CompareOptions", "regularExpression") and`
`484`		`- RegexEnableFlagFlow::flow(DataFlow::exprNode(sourceValue), optionsInput)`
`485`		`- )`
	`479`	`+ RegexEnableFlagFlow::flow(_, optionsInput)`
`486`	`480`	`}`
`487`	`481`	`}`