Merge pull request github#12780 from aibaars/shared-yaml-lib

JS: extract YAML library to a shared pack

Author: aibaars

javascript/ql/lib/change-notes/2023-04-17-shared-yaml-lib.md

@@ -0,0 +1,4 @@
+---
+category: majorAnalysis
+---
+* The Yaml.qll library was moved into a shared library pack named `codeql/yaml` to make it possible for other languages to re-use it. This change should be backwards compatible for existing JavaScript queries.

javascript/ql/lib/qlpack.yml

@@ -9,5 +9,6 @@ dependencies:
   codeql/regex: ${workspace}
   codeql/tutorial: ${workspace}
   codeql/util: ${workspace}
+  codeql/yaml: ${workspace}
 dataExtensions:
   - semmle/javascript/frameworks/**/model.yml

javascript/ql/lib/semmle/javascript/PrintAst.qll

@@ -51,7 +51,7 @@ private predicate isNotNeeded(Locatable el) {
 private string getQlClass(Locatable el) {
   result = "[" + el.getPrimaryQlClasses() + "] "
   // Alternative implementation -- do not delete. It is useful for QL class discovery.
-  // not el.getAPrimaryQlClass() = "???" and result = "[" + getPrimaryQlClasses() + "] " or el.getAPrimaryQlClass() = "???" and result = "??[" + concat(el.getAQlClass(), ",") + "] "
+  // not el.getAPrimaryQlClass() = "???" and result = "[" + el.getPrimaryQlClasses() + "] " or el.getAPrimaryQlClass() = "???" and result = "??[" + concat(el.getAQlClass(), ",") + "] "
 }
 
 /**