Skip to content

Commit e6e974a

Browse files
committed
Refactor CWE-079/SqlConcatenated
1 parent c1ee2dc commit e6e974a

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

java/ql/src/Security/CWE/CWE-079/XSSLocal.ql

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,17 +14,18 @@
1414
import java
1515
import semmle.code.java.dataflow.FlowSources
1616
import semmle.code.java.security.XSS
17-
import DataFlow::PathGraph
1817

19-
class XssLocalConfig extends TaintTracking::Configuration {
20-
XssLocalConfig() { this = "XSSLocalConfig" }
18+
private module XssLocalConfig implements DataFlow::ConfigSig {
19+
predicate isSource(DataFlow::Node source) { source instanceof LocalUserInput }
2120

22-
override predicate isSource(DataFlow::Node source) { source instanceof LocalUserInput }
23-
24-
override predicate isSink(DataFlow::Node sink) { sink instanceof XssSink }
21+
predicate isSink(DataFlow::Node sink) { sink instanceof XssSink }
2522
}
2623

27-
from DataFlow::PathNode source, DataFlow::PathNode sink, XssLocalConfig conf
28-
where conf.hasFlowPath(source, sink)
24+
module XssLocalFlow = TaintTracking::Make<XssLocalConfig>;
25+
26+
import XssLocalFlow::PathGraph
27+
28+
from XssLocalFlow::PathNode source, XssLocalFlow::PathNode sink
29+
where XssLocalFlow::hasFlowPath(source, sink)
2930
select sink.getNode(), source, sink, "Cross-site scripting vulnerability due to $@.",
3031
source.getNode(), "user-provided value"

0 commit comments

Comments
 (0)