Skip to content

Commit e8e8d97

Browse files
committed
Python: Remove all usage of DataFlow2+TaintTracking2
(and any higher number as well)
1 parent c665c21 commit e8e8d97

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

python/ql/lib/semmle/python/security/dataflow/PolynomialReDoSCustomizations.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
private import python
88
private import semmle.python.dataflow.new.DataFlow
9-
private import semmle.python.dataflow.new.DataFlow2
109
private import semmle.python.dataflow.new.TaintTracking
1110
private import semmle.python.Concepts
1211
private import semmle.python.dataflow.new.RemoteFlowSources

python/ql/src/experimental/semmle/python/security/TimingAttack.qll

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
private import python
2-
private import semmle.python.dataflow.new.TaintTracking2
32
private import semmle.python.dataflow.new.TaintTracking
43
private import semmle.python.dataflow.new.DataFlow
5-
private import semmle.python.dataflow.new.DataFlow2
64
private import semmle.python.ApiGraphs
75
private import semmle.python.dataflow.new.RemoteFlowSources
86
private import semmle.python.frameworks.Flask
@@ -164,7 +162,7 @@ class NonConstantTimeComparisonSink extends DataFlow::Node {
164162

165163
/** Holds if remote user input was used in the comparison. */
166164
predicate includesUserInput() {
167-
UserInputInComparisonFlow::flowTo(DataFlow2::exprNode(anotherParameter))
165+
UserInputInComparisonFlow::flowTo(DataFlow::exprNode(anotherParameter))
168166
}
169167
}
170168

@@ -175,7 +173,7 @@ class SecretSource extends DataFlow::Node {
175173
SecretSource() { secret = this.asExpr() }
176174

177175
/** Holds if the secret was deliverd by remote user. */
178-
predicate includesUserInput() { UserInputSecretFlow::flowTo(DataFlow2::exprNode(secret)) }
176+
predicate includesUserInput() { UserInputSecretFlow::flowTo(DataFlow::exprNode(secret)) }
179177
}
180178

181179
/** A string for `match` that identifies strings that look like they represent secret data. */

0 commit comments

Comments
 (0)