Apply suggestions from code review

Co-authored-by: Anders Schack-Mulligen <[email protected]>

Author: MathiasVP

shared/dataflow/change-notes/2023-08-02-dataflow-isSink.md

@@ -1,4 +1,4 @@
 ---
 category: feature
 ---
-* The `StateConfigSig` signature now supports an `isSink/1` predicate that does not specify the `FlowState` for which the given node is a sink. Instead, any `FlowState` is considered a valid `FlowState` for the sink.
+* The `StateConfigSig` signature now supports a unary `isSink` predicate that does not specify the `FlowState` for which the given node is a sink. Instead, any `FlowState` is considered a valid `FlowState` for such a sink.

shared/dataflow/codeql/dataflow/DataFlow.qll

@@ -114,7 +114,7 @@ module Configs<DataFlowParameter Lang> {
     predicate isSink(Node sink, FlowState state);
 
     /**
-     * Holds if `sink` is a relevant data flow sink.
+     * Holds if `sink` is a relevant data flow sink for any state.
      */
     default predicate isSink(Node sink) { none() }
 

shared/dataflow/codeql/dataflow/DataFlowImpl.qll

@@ -4069,7 +4069,7 @@ module MakeImpl<DataFlowParameter Lang> {
           NodeEx node, FlowState state, TRevSummaryCtx1 sc1, TRevSummaryCtx2 sc2,
           TRevSummaryCtx3 sc3, PartialAccessPath ap
         ) {
-          sinkNodeWithState(node, state) and
+          revSinkNode(node, state) and
           sc1 = TRevSummaryCtx1None() and
           sc2 = TRevSummaryCtx2None() and
           sc3 = TRevSummaryCtx3None() and
@@ -4287,7 +4287,7 @@ module MakeImpl<DataFlowParameter Lang> {
         }
 
         predicate isSink() {
-          sinkNodeWithState(node, state) and
+          revSinkNode(node, state) and
           sc1 = TRevSummaryCtx1None() and
           sc2 = TRevSummaryCtx2None() and
           sc3 = TRevSummaryCtx3None() and