Python: modules are now possibly non-unique

yoff · yoff · commit ed3ffde5e6b2 · 2023-09-29T15:10:19.000+02:00
We should consider if this is the right way..
diff --git a/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPublic.qll b/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPublic.qll
@@ -400,7 +400,7 @@ class ModuleVariableNode extends Node, TModuleVariableNode {
   override Scope getScope() { result = mod }
 
   override string toString() {
-    result = "ModuleVariableNode in " + mod.toString() + " for " + var.getId()
+    result = "ModuleVariableNode in " + concat( | | mod.toString(), ",") + " for " + var.getId()
   }
 
   /** Gets the module in which this variable appears. */

Original file line number	Diff line number	Diff line change
`@@ -400,7 +400,7 @@ class ModuleVariableNode extends Node, TModuleVariableNode {`
`400`	`400`	`override Scope getScope() { result = mod }`
`401`	`401`
`402`	`402`	`override string toString() {`
`403`		`- result = "ModuleVariableNode in " + mod.toString() + " for " + var.getId()`
	`403`	`+ result = "ModuleVariableNode in " + concat( \| \| mod.toString(), ",") + " for " + var.getId()`
`404`	`404`	`}`
`405`	`405`
`406`	`406`	`/** Gets the module in which this variable appears. */`