Skip to content

Commit ef3654f

Browse files
committed
PS: Small cleanup.
1 parent 5fde177 commit ef3654f

File tree

2 files changed

+1
-32
lines changed

2 files changed

+1
-32
lines changed

powershell/ql/lib/semmle/code/powershell/ast/internal/ChildIndex.qll

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,7 @@ newtype ChildIndex =
2626
ExprRedirection(int i) { exists(any(Raw::Cmd cmdExpr).getRedirection(i)) } or
2727
FunDefFun() or
2828
TypeDefType() or
29-
TypeMember(int i) {
30-
exists(any(Raw::TypeStmt typedef).getMember(i))
31-
// or
32-
// hasMemberInType(_, _, i, _)
33-
} or
29+
TypeMember(int i) { exists(any(Raw::TypeStmt typedef).getMember(i)) } or
3430
ThisVar() or
3531
PipelineIteratorVar() or
3632
PipelineByPropertyNameIteratorVar(Raw::PipelineByPropertyNameParameter p) or

powershell/ql/lib/semmle/code/powershell/dataflow/internal/DataFlowPrivate.qll

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1415,30 +1415,3 @@ ContentApprox getContentApprox(Content c) {
14151415
c instanceof Content::UnknownKeyOrPositionContent and
14161416
result = TUnknownContentApprox()
14171417
}
1418-
1419-
// TFieldContent(string name) {
1420-
// name = any(PropertyMember member).getName()
1421-
// or
1422-
// name = any(MemberExpr me).getMemberName()
1423-
// } or
1424-
// // A known map key
1425-
// TKnownKeyContent(ConstantValue cv) { exists(cv.asString()) } or
1426-
// // A known array index
1427-
// TKnownPositionalContent(ConstantValue cv) { cv.asInt() = [0 .. 10] } or
1428-
// // An unknown key
1429-
// TUnknownKeyContent() or
1430-
// // An unknown positional element
1431-
// TUnknownPositionalContent() or
1432-
// // A unknown position or key - and we dont even know what kind it is
1433-
// TUnknownKeyOrPositionContent()
1434-
/**
1435-
* A unit class for adding additional jump steps.
1436-
*
1437-
* Extend this class to add additional jump steps.
1438-
*/
1439-
class AdditionalJumpStep extends Unit {
1440-
/**
1441-
* Holds if data can flow from `pred` to `succ` in a way that discards call contexts.
1442-
*/
1443-
abstract predicate step(Node pred, Node succ);
1444-
}

0 commit comments

Comments
 (0)