Skip to content

Commit efa2bd8

Browse files
michaelnebeljcogs33
andcommitted
Apply suggestions from code review
Co-authored-by: Jami <[email protected]>
1 parent 8435c31 commit efa2bd8

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

csharp/ql/lib/semmle/code/csharp/dataflow/ExternalFlow.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* `namespace; type; subtypes; name; signature; ext; input; output; kind; provenance`
1414
* - Neutrals:
1515
* `namespace; type; name; signature; kind; provenance`
16-
* A neutral is used to indicate that there is no flow via a callable.
16+
* A neutral is used to indicate that a callable is neutral with respect to flow (no summary), source (is not a source) or sink (is not a sink).
1717
*
1818
* The interpretation of a row is similar to API-graphs with a left-to-right
1919
* reading.
@@ -105,7 +105,7 @@ predicate sinkModel = Extensions::sinkModel/9;
105105
/** Holds if a summary model exists for the given parameters. */
106106
predicate summaryModel = Extensions::summaryModel/10;
107107

108-
/** Holds if a model exists indicating there is no flow for the given parameters. */
108+
/** Holds if a neutral model exists for the given parameters. */
109109
predicate neutralModel = Extensions::neutralModel/6;
110110

111111
private predicate relevantNamespace(string namespace) {

csharp/ql/lib/semmle/code/csharp/dataflow/ExternalFlowExtensions.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ extensible predicate summaryModel(
2727
);
2828

2929
/**
30-
* Holds if a model exists indicating there is no flow for the given parameters.
30+
* Holds if a neutral model exists for the given parameters.
3131
*/
3232
extensible predicate neutralModel(
3333
string namespace, string type, string name, string signature, string kind, string provenance

java/ql/lib/semmle/code/java/dataflow/ExternalFlowExtensions.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ extensible predicate summaryModel(
2727
);
2828

2929
/**
30-
* Holds if a neutral model exists indicating there is no flow for the given parameters.
30+
* Holds if a neutral model exists for the given parameters.
3131
*/
3232
extensible predicate neutralModel(
3333
string package, string type, string name, string signature, string kind, string provenance

0 commit comments

Comments
 (0)