Refactor to use ThreatModelFlowSource

egregius313 · egregius313 · commit f237d2aeda4e · 2024-02-29T12:03:12.000-05:00
diff --git a/csharp/ql/lib/semmle/code/csharp/security/dataflow/ExternalAPIsQuery.qll b/csharp/ql/lib/semmle/code/csharp/security/dataflow/ExternalAPIsQuery.qll
@@ -92,7 +92,7 @@ class ExternalApiDataNode extends DataFlow::Node {
 deprecated class UntrustedDataToExternalApiConfig extends TaintTracking::Configuration {
   UntrustedDataToExternalApiConfig() { this = "UntrustedDataToExternalAPIConfig" }
 
-  override predicate isSource(DataFlow::Node source) { source instanceof RemoteFlowSource }
+  override predicate isSource(DataFlow::Node source) { source instanceof ThreatModelFlowSource }
 
   override predicate isSink(DataFlow::Node sink) { sink instanceof ExternalApiDataNode }
 }

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ class ExternalApiDataNode extends DataFlow::Node {`
`92`	`92`	`deprecated class UntrustedDataToExternalApiConfig extends TaintTracking::Configuration {`
`93`	`93`	`UntrustedDataToExternalApiConfig() { this = "UntrustedDataToExternalAPIConfig" }`
`94`	`94`
`95`		`- override predicate isSource(DataFlow::Node source) { source instanceof RemoteFlowSource }`
	`95`	`+ override predicate isSource(DataFlow::Node source) { source instanceof ThreatModelFlowSource }`
`96`	`96`
`97`	`97`	`override predicate isSink(DataFlow::Node sink) { sink instanceof ExternalApiDataNode }`
`98`	`98`	`}`