Skip to content

Commit f9afea8

Browse files
authored
Merge pull request github#13616 from kaspersv/kaspersv/enable-implicit-this
Enable implicit this warning CI checks
2 parents b2e8167 + dd54894 commit f9afea8

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

.github/workflows/check-implicit-this.yml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,13 @@
11
name: "Check implicit this warnings"
22

3-
on: workflow_dispatch
3+
on:
4+
workflow_dispatch:
5+
pull_request:
6+
paths:
7+
- "**qlpack.yml"
8+
branches:
9+
- main
10+
- "rc/*"
411

512
jobs:
613
check:
@@ -15,7 +22,7 @@ jobs:
1522
for pack_file in ${packs}; do
1623
option="$(yq '.warnOnImplicitThis' ${pack_file})"
1724
if [ "${option}" != "true" ]; then
18-
echo "warnOnImplicitThis property must be set to 'true' for pack ${pack_file}"
25+
echo "::error file=${pack_file}::warnOnImplicitThis property must be set to 'true' for pack ${pack_file}"
1926
EXIT_CODE=1
2027
fi
2128
done

0 commit comments

Comments
 (0)