use 1-based column locations for diagnostics

erik-krogh · erik-krogh · commit fe5e4845b182 · 2023-04-12T08:14:15.000+02:00
diff --git a/javascript/extractor/src/com/semmle/js/extractor/AutoBuild.java b/javascript/extractor/src/com/semmle/js/extractor/AutoBuild.java
@@ -1245,9 +1245,9 @@ private void doExtract(FileExtractor extractor, Path file, ExtractorState state)
         }
         DiagnosticLocation diagLoc = builder
             .setStartLine(err.getPosition().getLine())
-            .setStartColumn(err.getPosition().getColumn())
+            .setStartColumn(err.getPosition().getColumn() + 1) // convert from 0-based to 1-based
             .setEndLine(err.getPosition().getLine())
-            .setEndColumn(err.getPosition().getColumn())
+            .setEndColumn(err.getPosition().getColumn() + 1) // convert from 0-based to 1-based
             .build();
         writeDiagnostics(msg, JSDiagnosticKind.PARSE_ERROR, diagLoc);
       }

Original file line number	Diff line number	Diff line change
`@@ -1245,9 +1245,9 @@ private void doExtract(FileExtractor extractor, Path file, ExtractorState state)`
`1245`	`1245`	`}`
`1246`	`1246`	`DiagnosticLocation diagLoc = builder`
`1247`	`1247`	`.setStartLine(err.getPosition().getLine())`
`1248`		`- .setStartColumn(err.getPosition().getColumn())`
	`1248`	`+ .setStartColumn(err.getPosition().getColumn() + 1) // convert from 0-based to 1-based`
`1249`	`1249`	`.setEndLine(err.getPosition().getLine())`
`1250`		`- .setEndColumn(err.getPosition().getColumn())`
	`1250`	`+ .setEndColumn(err.getPosition().getColumn() + 1) // convert from 0-based to 1-based`
`1251`	`1251`	`.build();`
`1252`	`1252`	`writeDiagnostics(msg, JSDiagnosticKind.PARSE_ERROR, diagLoc);`
`1253`	`1253`	`}`