Ado auth extension is no longer silent

[Emilio0404]

Hello!

We recently started seeing this output from the ado auth extension in our codespaces :

> yarn build-scope acui-avatar
::step::Waiting for AzDO Authentication Helper...
::step::Running ado-auth-helper get-access-token...
::step::✓ Access token retrieved successfully

...

Is there a way to mute this output?

Thank you!

[markphip]

https://github.com/microsoft/codespace-features/blob/main/src/artifacts-helper/scripts/auth-ado.sh

[reillysiemens]

Could those be echo'd to stderr instead of stdout?

[markphip]

It can do whatever makes sense including removing the messages. Does Codespaces offer any kind of existing environment variable it could look at to decide when to send them and when not? They are useful when the command you are running is waiting for the auth helper to be installed so that you understand why the command is not doing anything.

Are the messages causing a problem?

[reillysiemens]

There's no environment variable that would fix this. In our particular case we're seeing console output from npm where there was previously none. It looks like #85 introduced some shims and then sources scripts which just write diagnostic output to stdout like that's no problem.

It definitely causes problems if you're trying to programmatically read the output of running a command. For example, we have a script that runs

const version = childProcess.execSync(`npm show ${package} version`, { encoding: "utf8" }).trim();

If npm now has a bunch of extraneous info on stdout then the output of npm show <package> version will include unexpected data for that program.

IMHO the shims need to be silent by default here.

[markphip]

Submit a PR that removes them or conditions them. I was more wondering if when Codespaces runs in Debug mode if there is something set that could be the only time they show. Or ir could just be a newly introduced one that someone could set when troubleshooting to see what is happening. Agree it could be silent by default

You can also use artifacts-helper:2

[reillysiemens]

We'll use artifacts-helper:2 until this gets fixed. Changing the output of shimmed command is a bug.

[reillysiemens]

I think a fix could involve a function which wraps echo. E.g.

log() {
  if [[ ${ARTIFACTS_HELPER_VERBOSE} == "true" ]]; then
    echo $@
  fi
}

[reillysiemens]

Thanks for being so quick on that, @markphip! We'll let you know how that fares.