refactor: standardize InternalsVisibleTo in csproj files (#1690)

Consolidate all [assembly: InternalsVisibleTo] attributes from scattered
.cs files into their respective .csproj files using MSBuild items.

Add cross-project InternalsVisibleTo entries to enable future phases of
making implementation details internal:
- Detectors → Orchestrator, Tests, TestsUtilities
- Common → Tests, Orchestrator, Detectors, TestsUtilities
- Orchestrator → Tests, CLI entry point, TestsUtilities
- Contracts → Tests, TestsUtilities

Remove scattered attributes from:
- ComponentRecorder.cs
- DependencyGraph.cs
- TelemetryConstants.cs
- IPyPiClient.cs

Part of #455

Author: JamieMagee

src/Microsoft.ComponentDetection.Common/DependencyGraph/ComponentRecorder.cs

@@ -1,19 +1,16 @@
 #nullable disable
+
+namespace Microsoft.ComponentDetection.Common.DependencyGraph;
+
 using System;
 using System.Collections.Concurrent;
 using System.Collections.Generic;
 using System.Collections.Immutable;
+using System.Collections.ObjectModel;
 using System.Linq;
-using System.Runtime.CompilerServices;
 using Microsoft.ComponentDetection.Contracts;
 using Microsoft.ComponentDetection.Contracts.BcdeModels;
 using Microsoft.ComponentDetection.Contracts.TypedComponent;
-
-[assembly: InternalsVisibleTo("Microsoft.ComponentDetection.Common.Tests")]
-
-namespace Microsoft.ComponentDetection.Common.DependencyGraph;
-
-using System.Collections.ObjectModel;
 using Microsoft.Extensions.Logging;
 
 public class ComponentRecorder : IComponentRecorder

src/Microsoft.ComponentDetection.Common/DependencyGraph/DependencyGraph.cs

@@ -1,19 +1,17 @@
 #nullable disable
+
+namespace Microsoft.ComponentDetection.Common.DependencyGraph;
+
 using System;
 using System.Collections.Concurrent;
 using System.Collections.Generic;
 using System.Collections.Immutable;
 using System.Linq;
-using System.Runtime.CompilerServices;
 using System.Text;
 using Microsoft.ComponentDetection.Contracts;
 using Microsoft.ComponentDetection.Contracts.BcdeModels;
 using Microsoft.ComponentDetection.Contracts.TypedComponent;
 
-[assembly: InternalsVisibleTo("Microsoft.ComponentDetection.Common.Tests")]
-
-namespace Microsoft.ComponentDetection.Common.DependencyGraph;
-
 internal class DependencyGraph : IDependencyGraph
 {
     private static readonly CompositeFormat MissingNodeFormat = CompositeFormat.Parse(Resources.MissingNodeInDependencyGraph);

src/Microsoft.ComponentDetection.Common/Microsoft.ComponentDetection.Common.csproj

@@ -1,5 +1,12 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
+    <ItemGroup>
+        <InternalsVisibleTo Include="Microsoft.ComponentDetection.Common.Tests" />
+        <InternalsVisibleTo Include="Microsoft.ComponentDetection.Orchestrator" />
+        <InternalsVisibleTo Include="Microsoft.ComponentDetection.Detectors" />
+        <InternalsVisibleTo Include="Microsoft.ComponentDetection.TestsUtilities" />
+    </ItemGroup>
+
     <ItemGroup>
         <PackageReference Include="Docker.DotNet" />
         <PackageReference Include="Microsoft.Extensions.Logging" />

src/Microsoft.ComponentDetection.Common/Telemetry/TelemetryConstants.cs

@@ -1,10 +1,7 @@
-using System;
-using System.Runtime.CompilerServices;
-
-[assembly: InternalsVisibleTo("Microsoft.ComponentDetection.Orchestrator")]
-
 namespace Microsoft.ComponentDetection.Common.Telemetry;
 
+using System;
+
 public static class TelemetryConstants
 {
     private static Guid correlationId;

src/Microsoft.ComponentDetection.Contracts/Microsoft.ComponentDetection.Contracts.csproj

@@ -6,6 +6,7 @@
 
     <ItemGroup>
         <InternalsVisibleTo Include="Microsoft.ComponentDetection.Contracts.Tests" />
+        <InternalsVisibleTo Include="Microsoft.ComponentDetection.TestsUtilities" />
     </ItemGroup>
 
     <ItemGroup>

src/Microsoft.ComponentDetection.Detectors/Microsoft.ComponentDetection.Detectors.csproj

@@ -1,5 +1,11 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
+    <ItemGroup>
+        <InternalsVisibleTo Include="Microsoft.ComponentDetection.Orchestrator" />
+        <InternalsVisibleTo Include="Microsoft.ComponentDetection.Detectors.Tests" />
+        <InternalsVisibleTo Include="Microsoft.ComponentDetection.TestsUtilities" />
+    </ItemGroup>
+
     <ItemGroup>
         <PackageReference Include="DotNet.Glob" />
         <PackageReference Include="Microsoft.Extensions.Logging" />

src/Microsoft.ComponentDetection.Detectors/pip/IPyPiClient.cs

@@ -1,4 +1,7 @@
 #nullable disable
+
+namespace Microsoft.ComponentDetection.Detectors.Pip;
+
 using System;
 using System.Collections.Generic;
 using System.IO;
@@ -7,7 +10,6 @@
 using System.Net.Http;
 using System.Net.Http.Headers;
 using System.Reflection;
-using System.Runtime.CompilerServices;
 using System.Text.Encodings.Web;
 using System.Text.Json;
 using System.Threading;
@@ -18,10 +20,6 @@
 using Microsoft.Extensions.Logging;
 using Polly;
 
-[assembly: InternalsVisibleTo("Microsoft.ComponentDetection.Detectors.Tests")]
-
-namespace Microsoft.ComponentDetection.Detectors.Pip;
-
 public interface IPyPiClient
 {
     Task<IList<PipDependencySpecification>> FetchPackageDependenciesAsync(string name, string version, PythonProjectRelease release);

src/Microsoft.ComponentDetection.Orchestrator/Microsoft.ComponentDetection.Orchestrator.csproj

@@ -1,5 +1,11 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
+    <ItemGroup>
+        <InternalsVisibleTo Include="Microsoft.ComponentDetection.Orchestrator.Tests" />
+        <InternalsVisibleTo Include="Microsoft.ComponentDetection" />
+        <InternalsVisibleTo Include="Microsoft.ComponentDetection.TestsUtilities" />
+    </ItemGroup>
+
     <ItemGroup>
         <PackageReference Include="CommandLineParser" />
         <PackageReference Include="DotNet.Glob" />