refactor: make Orchestrator implementation details internal (#1696)

Make 8 classes internal in the Orchestrator project:

- Converter classes: CommaDelimitedConverter, KeyValueDelimitedConverter,
  SemicolonDelimitedConverter
- CLI helpers: ArgumentHelper, IArgumentHelper
- Concrete service implementations: DetectorProcessingService,
  DetectorRestrictionService, DefaultGraphTranslationService

Kept public: ServiceCollectionExtensions, ScanExecutionService, ScanCommand,
ScanSettings, LoggingEnricher, DetectorRestrictions, all experiment types,
all service interfaces, DetectorRunResult, DetectorProcessingResult.

Part of #455

Author: JamieMagee

src/Microsoft.ComponentDetection.Orchestrator/ArgumentHelper.cs

@@ -5,7 +5,7 @@ namespace Microsoft.ComponentDetection.Orchestrator;
 using CommandLine;
 using Microsoft.ComponentDetection.Orchestrator.Commands;
 
-public class ArgumentHelper : IArgumentHelper
+internal class ArgumentHelper : IArgumentHelper
 {
     private readonly IEnumerable<ScanSettings> argumentSets;
 

src/Microsoft.ComponentDetection.Orchestrator/Extensions/CommaDelimitedConverter.cs

@@ -8,7 +8,7 @@ namespace Microsoft.ComponentDetection.Orchestrator.Extensions;
 /// <summary>
 /// Converts a comma separated string to an array of strings.
 /// </summary>
-public class CommaDelimitedConverter : TypeConverter
+internal class CommaDelimitedConverter : TypeConverter
 {
     /// <inheritdoc />
     public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, object value)

src/Microsoft.ComponentDetection.Orchestrator/Extensions/KeyValueDelimitedConverter.cs

@@ -9,7 +9,7 @@ namespace Microsoft.ComponentDetection.Orchestrator.Extensions;
 /// <summary>
 /// Converts a comma separated string of key value pairs to a dictionary.
 /// </summary>
-public class KeyValueDelimitedConverter : TypeConverter
+internal class KeyValueDelimitedConverter : TypeConverter
 {
     /// <inheritdoc />
     public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, object value)

src/Microsoft.ComponentDetection.Orchestrator/Extensions/SemicolonDelimitedConverter.cs

@@ -8,7 +8,7 @@ namespace Microsoft.ComponentDetection.Orchestrator.Extensions;
 /// <summary>
 /// Converts a semicolon separated string to an array of strings.
 /// </summary>
-public class SemicolonDelimitedConverter : TypeConverter
+internal class SemicolonDelimitedConverter : TypeConverter
 {
     /// <inheritdoc />
     public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, object value)

src/Microsoft.ComponentDetection.Orchestrator/IArgumentHelper.cs

@@ -2,7 +2,7 @@ namespace Microsoft.ComponentDetection.Orchestrator;
 
 using CommandLine;
 
-public interface IArgumentHelper
+internal interface IArgumentHelper
 {
     ParserResult<object> ParseArguments(string[] args);
 

src/Microsoft.ComponentDetection.Orchestrator/Microsoft.ComponentDetection.Orchestrator.csproj

@@ -4,6 +4,7 @@
         <InternalsVisibleTo Include="Microsoft.ComponentDetection.Orchestrator.Tests" />
         <InternalsVisibleTo Include="Microsoft.ComponentDetection" />
         <InternalsVisibleTo Include="Microsoft.ComponentDetection.TestsUtilities" />
+        <InternalsVisibleTo Include="DynamicProxyGenAssembly2" PublicKey="0024000004800000940000000602000000240000525341310004000001000100c547cac37abd99c8db225ef2f6c8a3602f3b3606cc9891605d02baa56104f4cfc0734aa39b93bf7852f7d9266654753cc297e7d2edfe0bac1cdcf9f717241550e0a7b191195b7667bb4f64bcb8e2121380fd1d9d46ad2d92d2d15605093924cceaf74c4861eff62abf69b9291ed0a340e113be11e6a7d3113e92484cf7045cc7" />
     </ItemGroup>
 
     <ItemGroup>

src/Microsoft.ComponentDetection.Orchestrator/Services/DetectorProcessingService.cs

@@ -22,7 +22,7 @@ namespace Microsoft.ComponentDetection.Orchestrator.Services;
 using Spectre.Console;
 using static System.Environment;
 
-public class DetectorProcessingService : IDetectorProcessingService
+internal class DetectorProcessingService : IDetectorProcessingService
 {
     private const int DefaultMaxDetectionThreads = 5;
     private const int ExperimentalTimeoutSeconds = 240; // 4 minutes

src/Microsoft.ComponentDetection.Orchestrator/Services/DetectorRestrictionService.cs

@@ -7,7 +7,7 @@ namespace Microsoft.ComponentDetection.Orchestrator.Services;
 using Microsoft.ComponentDetection.Orchestrator.Exceptions;
 using Microsoft.Extensions.Logging;
 
-public class DetectorRestrictionService : IDetectorRestrictionService
+internal class DetectorRestrictionService : IDetectorRestrictionService
 {
     private readonly IList<string> oldDetectorIds = ["MSLicenseDevNpm", "MSLicenseDevNpmList", "MSLicenseNpm", "MSLicenseNpmList"];
     private readonly string newDetectorId = "NpmWithRoots";

src/Microsoft.ComponentDetection.Orchestrator/Services/GraphTranslation/DefaultGraphTranslationService.cs

@@ -15,7 +15,7 @@ namespace Microsoft.ComponentDetection.Orchestrator.Services.GraphTranslation;
 using Microsoft.ComponentDetection.Orchestrator.Commands;
 using Microsoft.Extensions.Logging;
 
-public class DefaultGraphTranslationService : IGraphTranslationService
+internal class DefaultGraphTranslationService : IGraphTranslationService
 {
     private readonly ILogger<DefaultGraphTranslationService> logger;