Skip to content

Commit 97a53c5

Browse files
committed
use expect_throw for runtime_error
1 parent 898cde9 commit 97a53c5

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

lib/pal/PAL.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ namespace PAL_NS_BEGIN {
126126

127127
if (!pathExists || containsParentDirectory)
128128
{
129-
std::cerr << "Invalid trace folder path." << std::endl;
129+
throw std::runtime_error("Invalid trace folder path.");
130130
return false;
131131
}
132132

tests/unittests/PalTests.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,12 +193,12 @@ TEST_F(LogInitTest, LogInitValidPath)
193193

194194
TEST_F(LogInitTest, LogInitParentDirectoryInvalidPath)
195195
{
196-
EXPECT_FALSE(PAL::detail::log_init(true, "invalid/../path/"));
196+
EXPECT_THROW(PAL::detail::log_init(true, "invalid/../path/"), std::runtime_error);
197197
}
198198

199199
TEST_F(LogInitTest, LogInitPathDoesNotExist)
200200
{
201-
EXPECT_FALSE(PAL::detail::log_init(true, "nonexistent/path/"));
201+
EXPECT_THROW(PAL::detail::log_init(true, "nonexistent/path/"), std::runtime_error);
202202
}
203203

204204
TEST_F(LogInitTest, LogInitAlreadyInitialized)

0 commit comments

Comments
 (0)