New flag to scrub IP addresses #1161
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scrub IP addresses by default.
maxgolov
requested review from
kindbe,
mkoscumb,
reyang,
bliptec,
lalitb,
sid-dahiya and
ThomsonTan
as code owners
lalitb
approved these changes
Jun 7, 2023
|
MacOS CI tests failure can be ignored for now. |
|
@maxgolov Do you have plan to mark it for review, or else close if this is not valid ? |
|
@lalitb - we need it, but we identified an extra scenario that's not covered by the patch. I'll do another iteration on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement IP address scrub.