Fix a dangling reference in Schema::getTypes

wravery · wravery · commit 1af12ee83c5c · 2019-01-04T19:29:15.000-05:00
diff --git a/Introspection.cpp b/Introspection.cpp
@@ -51,8 +51,10 @@ void Schema::AddDirective(std::shared_ptr<object::__Directive> directive)
 
 std::future<std::vector<std::shared_ptr<object::__Type>>> Schema::getTypes(const std::shared_ptr<service::RequestState>&) const
 {
+	auto keepAlive = shared_from_this();
+
 	return std::async(std::launch::deferred,
-		[this]()
+		[this, keepAlive]()
 	{
 		std::vector<std::shared_ptr<object::__Type>> result(_types.size());
 

Original file line number	Diff line number	Diff line change
`@@ -51,8 +51,10 @@ void Schema::AddDirective(std::shared_ptr<object::__Directive> directive)`
`51`	`51`
`52`	`52`	`std::future<std::vector<std::shared_ptr<object::__Type>>> Schema::getTypes(const std::shared_ptr<service::RequestState>&) const`
`53`	`53`	`{`
	`54`	`+ auto keepAlive = shared_from_this();`
	`55`	`+`
`54`	`56`	`return std::async(std::launch::deferred,`
`55`		`- [this]()`
	`57`	`+ [this, keepAlive]()`
`56`	`58`	`{`
`57`	`59`	`std::vector<std::shared_ptr<object::__Type>> result(_types.size());`
`58`	`60`