Reset the state of the visitor between queries

Author: wravery

include/Validation.h

@@ -227,22 +227,26 @@ class ValidateExecutableVisitor
 	using OperationVariables = std::optional<VariableTypes>;
 	using VariableSet = std::set<std::string>;
 
+	// These members store Introspection schema information which does not change between queries.
 	OperationTypes _operationTypes;
 	ValidateTypeKinds _typeKinds;
 	MatchingTypes _matchingTypes;
 	Directives _directives;
 	EnumValues _enumValues;
 	ScalarTypes _scalarTypes;
 
+	// These members store information that's specific to a single query and changes every time we
+	// visit a new one. They must be reset in between queries.
 	ExecutableNodes _fragmentDefinitions;
 	ExecutableNodes _operationDefinitions;
+	FragmentSet _referencedFragments;
+	FragmentSet _fragmentCycles;
 
+	// These members store state for the visitor. They implicitly reset each time we call visit.
 	OperationVariables _operationVariables;
 	VariableDefinitions _variableDefinitions;
 	VariableSet _referencedVariables;
-	FragmentSet _referencedFragments;
 	FragmentSet _fragmentStack;
-	FragmentSet _fragmentCycles;
 	size_t _fieldCount = 0;
 	TypeFields _typeFields;
 	InputTypeFields _inputTypeFields;

src/Validation.cpp

@@ -792,6 +792,12 @@ std::vector<schema_error> ValidateExecutableVisitor::getStructuredErrors()
 {
 	auto errors = std::move(_errors);
 
+	// Reset all of the state for this query, but keep the Introspection schema information.
+	_fragmentDefinitions.clear();
+	_operationDefinitions.clear();
+	_referencedFragments.clear();
+	_fragmentCycles.clear();
+
 	return errors;
 }