Fix issues reported by VC++ Code Analysis

Author: wravery

GraphQLResponse.cpp

@@ -11,6 +11,9 @@ namespace response {
 
 Value::Value(Type type /*= Type::Null*/)
 	: _type(type)
+	, _boolean(false)
+	, _int(0)
+	, _float(0.0)
 {
 	switch (type)
 	{
@@ -28,18 +31,6 @@ Value::Value(Type type /*= Type::Null*/)
 			_string.reset(new StringType());
 			break;
 
-		case Type::Boolean:
-			_boolean = false;
-			break;
-
-		case Type::Int:
-			_int = 0;
-			break;
-
-		case Type::Float:
-			_float = 0;
-			break;
-
 		case Type::Scalar:
 			_scalar.reset(new Value());
 			break;
@@ -52,34 +43,49 @@ Value::Value(Type type /*= Type::Null*/)
 Value::Value(StringType&& value)
 	: _type(Type::String)
 	, _string(new StringType(std::move(value)))
+	, _boolean(false)
+	, _int(0)
+	, _float(0.0)
 {
 }
 
 Value::Value(BooleanType value)
 	: _type(Type::Boolean)
-	, _boolean(value)
+	, _boolean(false)
+	, _int(0)
+	, _float(0.0)
 {
+	_boolean = value;
 }
 
 Value::Value(IntType value)
 	: _type(Type::Int)
-	, _int(value)
+	, _boolean(false)
+	, _int(0)
+	, _float(0.0)
 {
+	_int = value;
 }
 
 Value::Value(FloatType value)
 	: _type(Type::Float)
-	, _float(value)
+	, _boolean(false)
+	, _int(0)
+	, _float(0.0)
 {
+	_float = value;
 }
 
-Value::Value(Value&& other)
+Value::Value(Value&& other) noexcept
 	: _type(other._type)
 	, _members(std::move(other._members))
 	, _map(std::move(other._map))
 	, _list(std::move(other._list))
 	, _string(std::move(other._string))
 	, _scalar(std::move(other._scalar))
+	, _boolean(false)
+	, _int(0)
+	, _float(0.0)
 {
 	switch (_type)
 	{
@@ -98,10 +104,18 @@ Value::Value(Value&& other)
 		default:
 			break;
 	}
+
+	const_cast<Type&>(other._type) = Type::Null;
+	other._boolean = false;
+	other._int = 0;
+	other._float = 0.0;
 }
 
 Value::Value(const Value& other)
 	: _type(other._type)
+	, _boolean(false)
+	, _int(0)
+	, _float(0.0)
 {
 	switch (_type)
 	{
@@ -140,7 +154,7 @@ Value::Value(const Value& other)
 	}
 }
 
-Value& Value::operator=(Value&& rhs)
+Value& Value::operator=(Value&& rhs) noexcept
 {
 	const_cast<Type&>(_type) = rhs._type;
 	const_cast<Type&>(rhs._type) = Type::Null;
@@ -150,19 +164,25 @@ Value& Value::operator=(Value&& rhs)
 	_list = std::move(rhs._list);
 	_string = std::move(rhs._string);
 	_scalar = std::move(rhs._scalar);
+	_boolean = false;
+	_int = 0;
+	_float = 0.0;
 
 	switch (_type)
 	{
 		case Type::Boolean:
 			_boolean = rhs._boolean;
+			rhs._boolean = false;
 			break;
 
 		case Type::Int:
 			_int = rhs._int;
+			rhs._int = 0;
 			break;
 
 		case Type::Float:
 			_float = rhs._float;
+			rhs._float = 0.0;
 			break;
 
 		default:

include/graphqlservice/GraphQLResponse.h

@@ -48,10 +48,10 @@ struct Value
 	explicit Value(IntType value);
 	explicit Value(FloatType value);
 
-	Value(Value&& other);
+	Value(Value&& other) noexcept;
 	explicit Value(const Value& other);
 
-	Value& operator=(Value&& rhs);
+	Value& operator=(Value&& rhs) noexcept;
 	Value& operator=(const Value& rhs) = delete;
 
 	// Check the Type