Defer decoding Base64 binary ID values till requested

wravery · wravery · commit 56839669188f · 2022-05-19T02:38:27.000-07:00
diff --git a/src/GraphQLResponse.cpp b/src/GraphQLResponse.cpp
@@ -882,9 +882,7 @@ IdType Value::release<IdType>()
 		{
 			auto stringValue = std::move(stringData.string);
 
-			return internal::Base64::validateBase64(stringValue)
-				? IdType { internal::Base64::fromBase64(stringValue) }
-				: IdType { std::move(stringValue) };
+			return IdType { std::move(stringValue) };
 		}
 	}
 	else if (std::holds_alternative<IdType>(_data))

Original file line number	Diff line number	Diff line change
`@@ -882,9 +882,7 @@ IdType Value::release<IdType>()`
`882`	`882`	`{`
`883`	`883`	`auto stringValue = std::move(stringData.string);`
`884`	`884`
`885`		`- return internal::Base64::validateBase64(stringValue)`
`886`		`- ? IdType { internal::Base64::fromBase64(stringValue) }`
`887`		`- : IdType { std::move(stringValue) };`
	`885`	`+ return IdType { std::move(stringValue) };`
`888`	`886`	`}`
`889`	`887`	`}`
`890`	`888`	`else if (std::holds_alternative<IdType>(_data))`