Skip to content

Commit 88ed5c6

Browse files
committed
Remove uneeded forward declares
1 parent 4bf0b78 commit 88ed5c6

File tree

8 files changed

+2
-54
lines changed

8 files changed

+2
-54
lines changed

include/SchemaGenerator.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ class PendingBlankLine
281281
bool reset() noexcept;
282282

283283
private:
284-
bool _pending = false;
284+
bool _pending = true;
285285
std::ostream& _outputFile;
286286
};
287287

samples/introspection/IntrospectionSchema.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616
namespace graphql {
1717
namespace introspection {
1818

19-
class Schema;
20-
2119
enum class TypeKind
2220
{
2321
SCALAR,

samples/separate/TodaySchema.h

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,6 @@
1414
#include <vector>
1515

1616
namespace graphql {
17-
namespace introspection {
18-
19-
class Schema;
20-
class ObjectType;
21-
22-
} /* namespace introspection */
23-
2417
namespace today {
2518

2619
enum class TaskState

samples/separate_nointrospection/TodaySchema.h

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,6 @@
1414
#include <vector>
1515

1616
namespace graphql {
17-
namespace introspection {
18-
19-
class Schema;
20-
class ObjectType;
21-
22-
} /* namespace introspection */
23-
2417
namespace today {
2518

2619
enum class TaskState

samples/unified/TodaySchema.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,6 @@
1414
#include <vector>
1515

1616
namespace graphql {
17-
namespace introspection {
18-
19-
class Schema;
20-
21-
} /* namespace introspection */
22-
2317
namespace today {
2418

2519
enum class TaskState

samples/unified_nointrospection/TodaySchema.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,6 @@
1414
#include <vector>
1515

1616
namespace graphql {
17-
namespace introspection {
18-
19-
class Schema;
20-
21-
} /* namespace introspection */
22-
2317
namespace today {
2418

2519
enum class TaskState

samples/validation/ValidationSchema.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,6 @@
1414
#include <vector>
1515

1616
namespace graphql {
17-
namespace introspection {
18-
19-
class Schema;
20-
21-
} /* namespace introspection */
22-
2317
namespace validation {
2418

2519
enum class DogCommand

src/SchemaGenerator.cpp

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1689,23 +1689,10 @@ bool Generator::outputHeader() const noexcept
16891689
)cpp";
16901690

16911691
NamespaceScope graphqlNamespace { headerFile, "graphql" };
1692-
NamespaceScope introspectionNamespace { headerFile, s_introspectionNamespace };
1693-
NamespaceScope schemaNamespace { headerFile, _schemaNamespace, true };
1692+
NamespaceScope schemaNamespace { headerFile, _schemaNamespace };
16941693
NamespaceScope objectNamespace { headerFile, "object", true };
16951694
PendingBlankLine pendingSeparator { headerFile };
16961695

1697-
headerFile << R"cpp(
1698-
class Schema;
1699-
)cpp";
1700-
1701-
if (_options.separateFiles)
1702-
{
1703-
headerFile << R"cpp(class ObjectType;
1704-
)cpp";
1705-
}
1706-
1707-
headerFile << std::endl;
1708-
17091696
std::string queryType;
17101697

17111698
if (!_isIntrospection)
@@ -1718,11 +1705,6 @@ class Schema;
17181705
break;
17191706
}
17201707
}
1721-
1722-
introspectionNamespace.exit();
1723-
headerFile << std::endl;
1724-
schemaNamespace.enter();
1725-
pendingSeparator.add();
17261708
}
17271709

17281710
if (!_enumTypes.empty())

0 commit comments

Comments
 (0)